New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 726007 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Roaming Profile GPO - Cannot set to Variable

Reported by matt.s.r...@gmail.com, May 24 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce the problem:
1. Enable saving to roaming profile per: https://support.google.com/chrome/a/answer/7349337?hl=en#
NOTE: I am using GPO to do this.
2. Set save location to a variable location: Example:  ${documents}\Chrome
3. Run GPUpdate on client
4. Run Chrome on client.
5. Check chrome://sync-internals/ and it will state that it is saving to defined variable location.
6. Go to said variable location and no file/folder is being generated. 

What is the expected behavior?
Save .pd file in expected location dictated by variable.

What went wrong?
Does not create file/folder in variable defined locations.

Did this work before? N/A 

Chrome version: 58.0.3029.110  Channel: stable
OS Version: 10.0
Flash Version: 

The GPO does apply properly according to chrome://policy, and the chrome://sync-internals/ does state that it is saving locally (unless I am reading wrong). 

Second side issue I believe related: 

Instead of setting to a variable location, set to any file path (C:/data). It will now generate file, but chrome will crash within 2min. I have not grabbed log as of yet. Will update with it, or create 2nd ticket if you want.
 
Cc: kkaluri@chromium.org pastarmovj@chromium.org ligim...@chromium.org nyerramilli@google.com ajha@chromium.org
Labels: Needs-Triage-M58
Labels: Needs-Feedback
Tested this on Windows 2K12 server with chrome #58.0.3029.110

These are the steps followed

1. Enabled the "RoamingProfileSupportEnabled" Policy
2. Set the "RoamingProfileLocation" policy to "C:\Users\Administrator\Documents\Chrome".
3. Updated the machine with "gpupdate /force"

Observed that under "C:\Users\Administrator\Documents\" no chrome folder is created, therefore there is no profile.pb created.

Attached a screen-cast for reference.

matt.s.reece@ Could you please look into it and confirm this issue or let us know any steps i have missed while reproducing the scenario.

Thank You...

Issue 726007.mp4
2.7 MB View Download
Hi kkaluri,

Yes that seems to show the same issue, where the policy is being applied but no file is generated. The only difference is you used an absolute value "C:\Users\Administrator\Documents\Chrome" and I used the variable location "${documents}\Chrome". 

But yes, that is the issue, not saving the .pd file.

-Matt
Project Member

Comment 4 by sheriffbot@chromium.org, May 25 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -pastarmovj@chromium.org
Owner: pastarmovj@chromium.org
Status: Assigned (was: Unconfirmed)
Julian, can you take a look at this issue.
Hi, I used sysinternals process monitor to monitor activity and see that it is not expanding the variable out to the path (tried with and without surrounding quotes). 

Screenshot attached.


variable-expansion-726007.PNG
12.6 KB View Download
Not to be pushy/rude, just out of curiosity: Any possible ETA on when this will be resolved? Would really like to deploy out this functionality (roaming profiles) to my networks as we use re-directed folders and this would allow us to finally move away from IE. 
Labels: -Pri-2 Pri-1
I am aiming at merging the fix for that in Chrome 60.

Meanwhile I can offer the following immediate workaround:

Create a drive letter mapping for the user roamed folder and then point the roaming profile location policy to there. This way you can deploy the feature now and then swap out the policy value and remove the mapping without having to migrate the file to a new location when the support for variables in the policy value is added.
Cc: georgesak@chromium.org pastarmovj@chromium.org blumberg@chromium.org
 Issue 728211  has been merged into this issue.
Status: Started (was: Assigned)
Labels: -Needs-Triage-M58 Merge-Request-60 M-60
Status: Fixed (was: Started)
Requesting merge for M60. This change is relatively trivial but the impact of it is significant for the users of the roaming profile feature. there is close to zero chance this merge can cause any stability issues on the release channel and its effect is perfectly confined to the users of the feature.
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 5 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I see that a fix has been merged with 60. Now is that Chrome v60.x.x.x? It is currently 58.x.x.x -- how long do we have to wait till v60.x is out so I can have this fix across my network? I do thank you for your awesome work, and quick response to the bug, just hoping to have it usable sooner rather then later. 
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16cd06ee6d187017a7813e2e8801b5b4471507b2

commit 16cd06ee6d187017a7813e2e8801b5b4471507b2
Author: Julian Pastarmov <pastarmovj@chromium.org>
Date: Mon Jun 05 18:36:49 2017

Add a path parsing policy handler for the RoamingProfileLocation policy.

This policy should like most other FilePath policies parse variables
in its content before storing its value in its backing pref.

BUG= 726007 
TEST=unit_tests

Review-Url: https://codereview.chromium.org/2912353003
Cr-Original-Commit-Position: refs/heads/master@{#476272}
Review-Url: https://codereview.chromium.org/2925643002 .
Cr-Commit-Position: refs/branch-heads/3112@{#163}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/16cd06ee6d187017a7813e2e8801b5b4471507b2/chrome/browser/BUILD.gn
[modify] https://crrev.com/16cd06ee6d187017a7813e2e8801b5b4471507b2/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[add] https://crrev.com/16cd06ee6d187017a7813e2e8801b5b4471507b2/chrome/browser/policy/local_sync_policy_handler.cc
[add] https://crrev.com/16cd06ee6d187017a7813e2e8801b5b4471507b2/chrome/browser/policy/local_sync_policy_handler.h
[add] https://crrev.com/16cd06ee6d187017a7813e2e8801b5b4471507b2/chrome/browser/policy/local_sync_policy_handler_unittest.cc
[modify] https://crrev.com/16cd06ee6d187017a7813e2e8801b5b4471507b2/chrome/test/BUILD.gn

Re #15: I also wish to get this fix in as soon as possible but 59 is as good as launched and therefore it is too risky to introduce this change in it. Please hang in there until 60 is out in a handful of weeks! :)
Labels: TE-Verified-M60 TE-Verified-60.0.3112.20
Verified this issue on Windows 10 with chrome #60.0.3112.20,

Observed .pd file in expected location dictated by variable.Hence adding TE-Verified labels.

Attaching screen-cast for reference.




Issue 726007.mp4
1.9 MB View Download
 Issue 733275  has been merged into this issue.
 Issue 738413  has been merged into this issue.
Yippy! v60 has gone live and I can confirm this is working :D THANK YOU!

Sign in to add a comment