New issue
Advanced search Search tips

Issue 726002 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature


Sign in to add a comment

Make Chromium able to use ANGLE on Android

Project Member Reported by ynovikov@chromium.org, May 24 2017

Issue description

- Link statically with ANGLE's GLES / EGL implementation (resolve conflicting symbol names with Chromium's GLES / EGL wrappers).
- Load ANGLE's GLES / EGL implementation instead of system.
- Make sure it works with pass-through command buffer.
- Get GPU tests passing with ANGLE.
 
Blockedon: 658763
Thanks for filing this! Blocking on issue 658763:
"Query ANGLE to decide whether WEBGL_compressed_texture_etc should be exposed"

This is to make sure we don't accidentally disable ETC textures without noticing when ANGLE ships on Android.

Comment 2 by kbr@chromium.org, Aug 10 2017

Blockedon: 754467
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09d09f469ee35065ca31e01a901a6fe23f5c72eb

commit 09d09f469ee35065ca31e01a901a6fe23f5c72eb
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Dec 14 23:25:17 2017

Conditionally link ANGLE statically into Android Chrome

When use_static_angle is set

BUG=726002

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4d716a48002f03af29a0280cd9207460e470143d
Reviewed-on: https://chromium-review.googlesource.com/822952
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524226}
[modify] https://crrev.com/09d09f469ee35065ca31e01a901a6fe23f5c72eb/gpu/BUILD.gn
[modify] https://crrev.com/09d09f469ee35065ca31e01a901a6fe23f5c72eb/gpu/config/BUILD.gn
[modify] https://crrev.com/09d09f469ee35065ca31e01a901a6fe23f5c72eb/gpu/config/gpu_info_collector_android.cc
[modify] https://crrev.com/09d09f469ee35065ca31e01a901a6fe23f5c72eb/ui/gl/BUILD.gn
[add] https://crrev.com/09d09f469ee35065ca31e01a901a6fe23f5c72eb/ui/gl/features.gni
[modify] https://crrev.com/09d09f469ee35065ca31e01a901a6fe23f5c72eb/ui/gl/init/BUILD.gn
[modify] https://crrev.com/09d09f469ee35065ca31e01a901a6fe23f5c72eb/ui/gl/init/gl_initializer_android.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70019b573ffe4286555c2b340a341f6ff064b915

commit 70019b573ffe4286555c2b340a341f6ff064b915
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Oct 03 15:56:53 2018

Fix use_static_angle build flag and require a flag to use ANGLE.

ui/gl initialization is now in a sub library, move the dependencies.

Require a flag to use ANGLE on Android, this allows ANGLE and the native
driver to both work with a given build so we can test on the bots.

BUG=726002

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2d3e0c4e844dca9e72c363f07e011c710e1a9f57
Reviewed-on: https://chromium-review.googlesource.com/c/1244078
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596236}
[modify] https://crrev.com/70019b573ffe4286555c2b340a341f6ff064b915/ui/gl/BUILD.gn
[modify] https://crrev.com/70019b573ffe4286555c2b340a341f6ff064b915/ui/gl/init/BUILD.gn
[modify] https://crrev.com/70019b573ffe4286555c2b340a341f6ff064b915/ui/gl/init/gl_initializer_android.cc

Cc: ynovikov@chromium.org
Owner: geoffl...@chromium.org
Status: Started (was: Assigned)

Sign in to add a comment