New issue
Advanced search Search tips

Issue 725999 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

MD Settings for Printing Section

Project Member Reported by weifangsun@chromium.org, May 24 2017

Issue description

When moving from the previous Settings page to MD Settings, it looks like we dropped the "Learn More" link for the native printing option.

I noticed that for GCP, the "Set up or manage printers in Google Cloud Print. Learn More" string is now on the sub-page with a different string in the main settings page.

We should be consistent in this presentation.

shibasheikh@, could you advise on -

1. Should we move the information string to the main settings page, sub-page, or both?
2. I'd like to add the following string for the native printing option: "Set up or manage local printers. Learn more" (link to support article)
 
Cc: -x...@chromium.org shibasheikh@chromium.org
Owner: x...@chromium.org
Spoke with shibasheikh@ last week. To summarize approach -

1. Add a sub-title to the Printers menu item that states "Set up or manage printers locally. Learn more" -- Learn more should link to the support page for printing (https://support.google.com/chromebook?p=chromebook_printing).

2. Rename the sub-title for the Google Cloud Print menu item to "Set up or manage printers in Google Cloud Print. Learn more" (from the sub-page).

3. Remove the line from the sub-page at the top for Google Cloud Print.
Cc: x...@chromium.org
Owner: weifangsun@chromium.org
We prefer to avoid "Learn more" links in clickable rows where possible. It makes it strange that clicking anywhere in the row but on the link will take you to the subpage. I think it makes more sense to have the link on the subpage, as we currently do with GCP.

We decided to try have the link in a clickable row with Google Play because there isn't always a subpage, and it's currently broken (will both open a new tab and take you to a subpage).
Cc: -x...@chromium.org weifangsun@chromium.org
Owner: x...@chromium.org
Thanks for the feedback Tom!

In that case, let's remove (1) the sub-title from the Google Cloud Print option in the main settings page and (2) add the Printer info line to the sub-page.

shibasheikh@ - Please advise if you have any additional thoughts on this.

Comment 4 by x...@chromium.org, Jun 13 2017

Re weifangsun@: the sub-title from the Google Cloud Print option doesn't have a "Learn more" link today. Do we still want to remove the sub-title?

If we want to add the Printer info "Learn more" link to the sub-page of the Printers option, could you provide a mock for the sub-page?
Cc: -shibasheikh@chromium.org x...@chromium.org
Owner: shibasheikh@chromium.org
For the first question - Yes, I think we should remove the sub-title completely from the Settings page for both Printers and Google Cloud Print options and have the information on the subpage.

For the mock - shibasheikh@, could you please provide?
Attached mock for string treatment
Screen Shot 2017-06-23 at 2.23.03 PM.png
126 KB View Download

Comment 7 by x...@chromium.org, Jul 14 2017

See attached screenshots with "Learn more" link with/without internet connection. 
Screenshot 2017-07-14 at 10.59.18.png
181 KB View Download
Screenshot 2017-07-14 at 10.59.31.png
187 KB View Download
xdai@ - Thanks for the screenshots!!

On review, I think the second one (no internet) looks a little crowded/awkward with the current text placement so have asked shibasheikh@ to provide an updated mock for this.
Hi some implementation feedback :

- Rule lines should be end to end (go all the way edge to edge) and 8% alpha
- The description text should be aligned with the arrow and not indented
- the ADD PRINTER button is wrong. Needs to be Roboto Medium all caps 28 weight, 26% opacity
- the search box hint text should be "Search printers"
Screen Shot 2017-07-14 at 2.23.59 PM.png
130 KB View Download
Cc: -x...@chromium.org shibasheikh@chromium.org
Owner: x...@chromium.org
Thanks Shiba! xdai@ - Please let me know if you have any questions.

Comment 11 by x...@chromium.org, Jul 14 2017

shibasheikh@: What is all caps 28 weight? See font-weight css style https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight, seems 28 doesn't make sense.

Do we need to modify the font-weight of ADD PRINTER button for both online/offline cases?

Comment 12 by x...@chromium.org, Jul 14 2017

About the row line: Previously it went all the way edge to edge, but it was modified to the current style in stevenjb@'s CL https://codereview.chromium.org/2906893003/ to be consistent with the current MD setting spec. I checked with Weifang and she was fine with the change.

Comment 13 by x...@chromium.org, Jul 14 2017

See the new screenshots.
Note: it's using the default font weight of ADD PRINTER button.
Screenshot 2017-07-14 at 16.16.04.png
182 KB View Download
Screenshot 2017-07-14 at 16.15.37.png
175 KB View Download
xdai@ - The new screenshots look great! Thanks for the quick turn around :)
@xdai looks good! A couple thoughts:

1) Should the "ADD PRINTER" button just be "ADD"?
2) It looks like the font isn't medium weight, though that could just be if you're running it on Linux (I've seen that happen before)
3) Should there be a separate header for the list saying "Printers", with the "ADD" button in-line? See screenshot from Autofill.
Screenshot 2017-07-17 at 10.30.46 AM.png
18.8 KB View Download

Comment 17 by x...@chromium.org, Jul 18 2017

Weifang: Could you help answer the question 1) and 3) in #15 from PM's point of view? Thanks!

For question 2): The font is not weighted on purpose, I just used the default font weight that we're using for primary-button. Let me know if I should use a certain weight on the font according to the md's spec. 

Comment 18 by x...@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)
On 1 & 3 - I think that we should keep the current implemented layout with the "Add Printer" approach. My thought here is that because we have the additional text description on the left hand side + possible info message, the additional header would become crowded.

Comment 20 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment