MD Settings for Printing Section |
|||||||
Issue descriptionWhen moving from the previous Settings page to MD Settings, it looks like we dropped the "Learn More" link for the native printing option. I noticed that for GCP, the "Set up or manage printers in Google Cloud Print. Learn More" string is now on the sub-page with a different string in the main settings page. We should be consistent in this presentation. shibasheikh@, could you advise on - 1. Should we move the information string to the main settings page, sub-page, or both? 2. I'd like to add the following string for the native printing option: "Set up or manage local printers. Learn more" (link to support article)
,
Jun 12 2017
We prefer to avoid "Learn more" links in clickable rows where possible. It makes it strange that clicking anywhere in the row but on the link will take you to the subpage. I think it makes more sense to have the link on the subpage, as we currently do with GCP. We decided to try have the link in a clickable row with Google Play because there isn't always a subpage, and it's currently broken (will both open a new tab and take you to a subpage).
,
Jun 13 2017
Thanks for the feedback Tom! In that case, let's remove (1) the sub-title from the Google Cloud Print option in the main settings page and (2) add the Printer info line to the sub-page. shibasheikh@ - Please advise if you have any additional thoughts on this.
,
Jun 13 2017
Re weifangsun@: the sub-title from the Google Cloud Print option doesn't have a "Learn more" link today. Do we still want to remove the sub-title? If we want to add the Printer info "Learn more" link to the sub-page of the Printers option, could you provide a mock for the sub-page?
,
Jun 19 2017
For the first question - Yes, I think we should remove the sub-title completely from the Settings page for both Printers and Google Cloud Print options and have the information on the subpage. For the mock - shibasheikh@, could you please provide?
,
Jun 23 2017
Attached mock for string treatment
,
Jul 14 2017
See attached screenshots with "Learn more" link with/without internet connection.
,
Jul 14 2017
xdai@ - Thanks for the screenshots!! On review, I think the second one (no internet) looks a little crowded/awkward with the current text placement so have asked shibasheikh@ to provide an updated mock for this.
,
Jul 14 2017
Hi some implementation feedback : - Rule lines should be end to end (go all the way edge to edge) and 8% alpha - The description text should be aligned with the arrow and not indented - the ADD PRINTER button is wrong. Needs to be Roboto Medium all caps 28 weight, 26% opacity - the search box hint text should be "Search printers"
,
Jul 14 2017
Thanks Shiba! xdai@ - Please let me know if you have any questions.
,
Jul 14 2017
shibasheikh@: What is all caps 28 weight? See font-weight css style https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight, seems 28 doesn't make sense. Do we need to modify the font-weight of ADD PRINTER button for both online/offline cases?
,
Jul 14 2017
About the row line: Previously it went all the way edge to edge, but it was modified to the current style in stevenjb@'s CL https://codereview.chromium.org/2906893003/ to be consistent with the current MD setting spec. I checked with Weifang and she was fine with the change.
,
Jul 14 2017
See the new screenshots. Note: it's using the default font weight of ADD PRINTER button.
,
Jul 17 2017
xdai@ - The new screenshots look great! Thanks for the quick turn around :)
,
Jul 17 2017
@xdai looks good! A couple thoughts: 1) Should the "ADD PRINTER" button just be "ADD"? 2) It looks like the font isn't medium weight, though that could just be if you're running it on Linux (I've seen that happen before) 3) Should there be a separate header for the list saying "Printers", with the "ADD" button in-line? See screenshot from Autofill.
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81feb919232541c4897821b842943f43f5e3cbaf commit 81feb919232541c4897821b842943f43f5e3cbaf Author: xdai <xdai@chromium.org> Date: Tue Jul 18 00:16:17 2017 [CUPS] Remove sub-title from Cloud Print and add CUPS print info line. Bug: 725999 Change-Id: I78948e0d82f88a4303877788ddf7db7df60e3654 Reviewed-on: https://chromium-review.googlesource.com/570808 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487313} [modify] https://crrev.com/81feb919232541c4897821b842943f43f5e3cbaf/chrome/app/settings_strings.grdp [modify] https://crrev.com/81feb919232541c4897821b842943f43f5e3cbaf/chrome/browser/resources/settings/printing_page/cups_printers.html [modify] https://crrev.com/81feb919232541c4897821b842943f43f5e3cbaf/chrome/browser/resources/settings/printing_page/printing_page.html [modify] https://crrev.com/81feb919232541c4897821b842943f43f5e3cbaf/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/81feb919232541c4897821b842943f43f5e3cbaf/chrome/common/url_constants.cc [modify] https://crrev.com/81feb919232541c4897821b842943f43f5e3cbaf/chrome/common/url_constants.h
,
Jul 18 2017
Weifang: Could you help answer the question 1) and 3) in #15 from PM's point of view? Thanks! For question 2): The font is not weighted on purpose, I just used the default font weight that we're using for primary-button. Let me know if I should use a certain weight on the font according to the md's spec.
,
Jul 18 2017
,
Jul 18 2017
On 1 & 3 - I think that we should keep the current implemented layout with the "Add Printer" approach. My thought here is that because we have the additional text description on the left hand side + possible info message, the additional header would become crowded.
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by weifangsun@chromium.org
, Jun 12 2017Owner: x...@chromium.org