New issue
Advanced search Search tips

Issue 725990 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 671246



Sign in to add a comment

mash: Remove ConfigureWidgetInitParamsForContainer

Project Member Reported by jamescook@chromium.org, May 24 2017

Issue description

I was needed when we supported mus ui::Window. Now with mus-aura we can directly specify the widget parent.

 

Comment 1 by sky@chromium.org, Jun 26 2017

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66193f75971bb58ae02aac4cb44f3cdf72479bd4

commit 66193f75971bb58ae02aac4cb44f3cdf72479bd4
Author: Scott Violet <sky@chromium.org>
Date: Mon Jun 26 23:51:01 2017

chromeos: removes RootWindowController::ConfigureWidgetInitParamsForContainer

BUG= 725990 
TEST=covered by tests

Change-Id: I87a2925e8035eed7ae2133848fee7463a3fe8ced
Reviewed-on: https://chromium-review.googlesource.com/549016
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482472}
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/drag_drop/drag_image_view.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/mus/top_level_window_factory.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/root_window_controller.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/root_window_controller.h
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/shelf/overflow_bubble_view.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/shelf/overflow_bubble_view.h
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/system/session/logout_confirmation_dialog.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/system/status_area_widget.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/system/toast/toast_overlay.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/system/user/user_view.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/test/ash_test_base.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/window_cycle_list.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/ash/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/66193f75971bb58ae02aac4cb44f3cdf72479bd4/chrome/browser/chromeos/accessibility/accessibility_manager.cc

Comment 3 by sky@chromium.org, Jun 26 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment