New issue
Advanced search Search tips

Issue 725985 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocking:
issue 674991



Sign in to add a comment

Remove -[CRWWebDelegate webWillReload]

Project Member Reported by eugene...@chromium.org, May 24 2017

Issue description

This should be replaced with WebStateObserver::DidStartNavigation and clients should check context's transition type to filter reloads.
 
Blocking: 674991
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b23d2a4dca1f06ef6d935b2612c2d050fc408338

commit b23d2a4dca1f06ef6d935b2612c2d050fc408338
Author: eugenebut <eugenebut@chromium.org>
Date: Fri May 26 21:43:49 2017

Use ui::PAGE_TRANSITION_RELOAD transition for web page reload.

This will allow replacing -[CRWWebDelegate webWillReload] with
DidStartNavigation, because correct PageTransition will be passed to
DidStartNavigation callback.

BUG= 725985 

Review-Url: https://codereview.chromium.org/2910453002
Cr-Commit-Position: refs/heads/master@{#475143}

[modify] https://crrev.com/b23d2a4dca1f06ef6d935b2612c2d050fc408338/ios/web/web_state/navigation_callbacks_inttest.mm
[modify] https://crrev.com/b23d2a4dca1f06ef6d935b2612c2d050fc408338/ios/web/web_state/ui/crw_web_controller.mm

Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72efed69faa7e40480308c569ebcbc90250007d4

commit 72efed69faa7e40480308c569ebcbc90250007d4
Author: eugenebut <eugenebut@chromium.org>
Date: Tue May 30 17:00:02 2017

Removed -[CRWWebDelegate webWillReload] callback.

Replaced with WebStateObserver::DidStartNavigation where Tab checks
context's transition type to filter reloads.

BUG= 725985 

Review-Url: https://codereview.chromium.org/2903173003
Cr-Commit-Position: refs/heads/master@{#475570}

[modify] https://crrev.com/72efed69faa7e40480308c569ebcbc90250007d4/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/72efed69faa7e40480308c569ebcbc90250007d4/ios/web/public/web_state/ui/crw_web_delegate.h
[modify] https://crrev.com/72efed69faa7e40480308c569ebcbc90250007d4/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment