Remove -[CRWWebDelegate webWillReload] |
||
Issue descriptionThis should be replaced with WebStateObserver::DidStartNavigation and clients should check context's transition type to filter reloads.
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b23d2a4dca1f06ef6d935b2612c2d050fc408338 commit b23d2a4dca1f06ef6d935b2612c2d050fc408338 Author: eugenebut <eugenebut@chromium.org> Date: Fri May 26 21:43:49 2017 Use ui::PAGE_TRANSITION_RELOAD transition for web page reload. This will allow replacing -[CRWWebDelegate webWillReload] with DidStartNavigation, because correct PageTransition will be passed to DidStartNavigation callback. BUG= 725985 Review-Url: https://codereview.chromium.org/2910453002 Cr-Commit-Position: refs/heads/master@{#475143} [modify] https://crrev.com/b23d2a4dca1f06ef6d935b2612c2d050fc408338/ios/web/web_state/navigation_callbacks_inttest.mm [modify] https://crrev.com/b23d2a4dca1f06ef6d935b2612c2d050fc408338/ios/web/web_state/ui/crw_web_controller.mm
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72efed69faa7e40480308c569ebcbc90250007d4 commit 72efed69faa7e40480308c569ebcbc90250007d4 Author: eugenebut <eugenebut@chromium.org> Date: Tue May 30 17:00:02 2017 Removed -[CRWWebDelegate webWillReload] callback. Replaced with WebStateObserver::DidStartNavigation where Tab checks context's transition type to filter reloads. BUG= 725985 Review-Url: https://codereview.chromium.org/2903173003 Cr-Commit-Position: refs/heads/master@{#475570} [modify] https://crrev.com/72efed69faa7e40480308c569ebcbc90250007d4/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/72efed69faa7e40480308c569ebcbc90250007d4/ios/web/public/web_state/ui/crw_web_delegate.h [modify] https://crrev.com/72efed69faa7e40480308c569ebcbc90250007d4/ios/web/web_state/ui/crw_web_controller.mm
,
May 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, May 24 2017