New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725984 link

Starred by 1 user
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove canvas 2d dynamic rendering mode switching

Project Member Reported by junov@chromium.org, May 24 2017 
dynamic rendering mode switching was an experiment.

The experiment successfully demonstrated that we should not do the dynamic switching. The heuristics are simply too much of a burden to maintain for the feature to be useful.  Also, with the acceleration of pat rendering, it is no longer very relevant.

Time to rip out the code.
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d09c4ba903d520f3aea3c2fcf1e2cf742828290

commit 1d09c4ba903d520f3aea3c2fcf1e2cf742828290
Author: junov <junov@chromium.org>
Date: Thu May 25 17:22:23 2017

Removing canvas rendering mode switching feature

This feature was abandoned.  Cleaning out the code
BUG= 725984 
TBR=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2903053002
Cr-Commit-Position: refs/heads/master@{#474685}

[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/chrome/browser/about_flags.cc
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/content/child/runtime_features.cc
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/content/public/common/content_switches.cc
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/content/public/common/content_switches.h
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[delete] https://crrev.com/523a95201db3bb5e44157e5ca2bf9e4e2b41e0be/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp
[delete] https://crrev.com/523a95201db3bb5e44157e5ca2bf9e4e2b41e0be/third_party/WebKit/Source/modules/canvas2d/tools/GeneratePerformanceData.html
[delete] https://crrev.com/523a95201db3bb5e44157e5ca2bf9e4e2b41e0be/third_party/WebKit/Source/modules/canvas2d/tools/GeneratePerformanceData.js
[delete] https://crrev.com/523a95201db3bb5e44157e5ca2bf9e4e2b41e0be/third_party/WebKit/Source/modules/canvas2d/tools/README.md
[delete] https://crrev.com/523a95201db3bb5e44157e5ca2bf9e4e2b41e0be/third_party/WebKit/Source/modules/canvas2d/tools/bench.js
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[add] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/platform/graphics/CanvasHeuristicParameters.h
[delete] https://crrev.com/523a95201db3bb5e44157e5ca2bf9e4e2b41e0be/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/1d09c4ba903d520f3aea3c2fcf1e2cf742828290/tools/metrics/histograms/enums.xml

Comment 2 by junov@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment