New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725971 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
dbeam@chromium.org
patricia...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

js_checker.py failing on route.js

Project Member Reported by steve...@chromium.org, May 24 2017 
** Presubmit Messages **
See the JavaScript style guide at https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md#JavaScript
** Presubmit ERRORS **
Found JavaScript style violations in chrome/browser/resources/settings/route.js:
  line 311: Please use var namesLikeThis <https://goo.gl/eQiXVW>
  var lastRouteChangeWasPopstate_ = false;
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is preventing a CL from getting through the CQ.

I'm not sure if the correct thing to do is to change the presubmit warning, or change the var name in route.js?

Comment 1 by dbeam@chromium.org, May 24 2017

Cc: dbeam@chromium.org
Labels: -Pri-1 Pri-2
Owner: patricia...@chromium.org
Status: Started (was: Assigned)
already being fixed here
https://chromium-review.googlesource.com/c/504067/

this is not a P1 because it's 1 file and you can use NOPRESUBMIT=true if necessary

Comment 2 by patricia...@chromium.org, Sep 6 2017

Cc: -dschuyler@chromium.org patricia...@chromium.org
Labels: OS-Linux OS-Mac OS-Windows
Owner: dschuyler@chromium.org
Status: Fixed (was: Started)
This was fixed in https://codereview.chromium.org/2912473004
►

Sign in to add a comment