Fix payment request completion status on Android |
|||||||||
Issue descriptionDuring a CL that went into 59, the logged value was modified by mistake. this fixes it.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ae43cad500350d2637d42a972f11d8b7489879a commit 9ae43cad500350d2637d42a972f11d8b7489879a Author: sebsg <sebsg@chromium.org> Date: Wed May 24 19:27:20 2017 [Payments] Fix metric log. BUG= 725960 Review-Url: https://codereview.chromium.org/2899083005 Cr-Commit-Position: refs/heads/master@{#474387} [modify] https://crrev.com/9ae43cad500350d2637d42a972f11d8b7489879a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/9ae43cad500350d2637d42a972f11d8b7489879a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
,
May 24 2017
,
May 24 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 24 2017
Hi amineer, I know we are pretty late, but it would be great to merge this small patch. The only change is logging a different enum value that was changed by mistake in another CL. Let me know what you think, thanks.
,
May 24 2017
,
May 25 2017
Starting with M60 this request would be rejected, we should not be tweaking metrics this late. Since we haven't sent out new guidelines yet though, we can take this, but let's be more diligent in the future please.
,
May 25 2017
Sure, thank you.
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4596f0b8b3e563b3d1767b03fbbc521226717428 commit 4596f0b8b3e563b3d1767b03fbbc521226717428 Author: sebsg <sebsg@chromium.org> Date: Thu May 25 13:34:07 2017 Merge-59 [Payments] Fix metric log. BUG= 725960 Review-Url: https://codereview.chromium.org/2899083005 Cr-Commit-Position: refs/heads/master@{#474387} (cherry picked from commit 9ae43cad500350d2637d42a972f11d8b7489879a) TBR=gogerald@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2905063002 Cr-Commit-Position: refs/branch-heads/3071@{#693} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/4596f0b8b3e563b3d1767b03fbbc521226717428/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/4596f0b8b3e563b3d1767b03fbbc521226717428/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java
,
May 26 2017
,
Jun 27 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by se...@chromium.org
, May 24 2017