New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725960 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Fix payment request completion status on Android

Project Member Reported by se...@chromium.org, May 24 2017

Issue description

During a CL that went into 59, the logged value was modified by mistake. this fixes it.
 

Comment 1 by se...@chromium.org, May 24 2017

The mixup happened in this CL https://codereview.chromium.org/2750103005

Comment 3 by se...@chromium.org, May 24 2017

Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 24 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by se...@chromium.org, May 24 2017

Cc: amineer@chromium.org
Hi amineer, I know we are pretty late, but it would be great to merge this small patch. The only change is logging a different enum value that was changed by mistake in another CL.

Let me know what you think, thanks.

Comment 6 by se...@chromium.org, May 24 2017

Components: UI>Browser>Autofill>Payments
Labels: -Merge-Review-59 Merge-Approved-59
Starting with M60 this request would be rejected, we should not be tweaking metrics this late.  Since we haven't sent out new guidelines yet though, we can take this, but let's be more diligent in the future please.

Comment 8 by se...@chromium.org, May 25 2017

Sure, thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, May 25 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4596f0b8b3e563b3d1767b03fbbc521226717428

commit 4596f0b8b3e563b3d1767b03fbbc521226717428
Author: sebsg <sebsg@chromium.org>
Date: Thu May 25 13:34:07 2017

Merge-59 [Payments] Fix metric log.

BUG= 725960 
Review-Url: https://codereview.chromium.org/2899083005
Cr-Commit-Position: refs/heads/master@{#474387}
(cherry picked from commit 9ae43cad500350d2637d42a972f11d8b7489879a)

TBR=gogerald@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2905063002
Cr-Commit-Position: refs/branch-heads/3071@{#693}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/4596f0b8b3e563b3d1767b03fbbc521226717428/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/4596f0b8b3e563b3d1767b03fbbc521226717428/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java

Comment 10 by se...@chromium.org, May 26 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment