New issue
Advanced search Search tips

Issue 725946 link

Starred by 1 user
Status: Fixed
Owner:
estevenson@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

diagnose_bloat.py fails when --cloud is used

Project Member Reported by estevenson@chromium.org, May 24 2017 
Android perf builders recently changed output dirs to be full-build-linux (like the Linux ones already are), and diagnose_bloat.py assumes the output directory will be out/Release for Android perf builders.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55ab51da0975fec0f5c63d62cf7d3e334d67ad29

commit 55ab51da0975fec0f5c63d62cf7d3e334d67ad29
Author: Eric Stevenson <estevenson@chromium.org>
Date: Wed May 24 20:59:14 2017

diagnose_bloat.py: fix broken output directory.

Recently the output directory for Android perf builders has changed
from out/Release to full-build-linux.

This CL updates the extraction logic to use the common prefix for all
files in the archive instead of hardcoding an expected output directory.

Also updated the README to explicitly note that diagnose_bloat.py can
be used to download archived .size files.

Bug:  725946 
Change-Id: Ia7ea97022520adb9fd9f56a58281ff5f20fbe60f
Reviewed-on: https://chromium-review.googlesource.com/513501
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474419}
[modify] https://crrev.com/55ab51da0975fec0f5c63d62cf7d3e334d67ad29/tools/binary_size/README.md
[modify] https://crrev.com/55ab51da0975fec0f5c63d62cf7d3e334d67ad29/tools/binary_size/diagnose_bloat.py

Comment 2 by estevenson@chromium.org, May 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment