DEPS presubmit finds false positives on Windows |
||||
Issue description(newb here - the bug is possibly filed with the wrong component / missing labels) _CalculateAddedDeps calls into depot tools' scm.py GetOldContents to compare previous and current versions of the DEPS file. GetOldContents attempts to 'git show <sha>:<path>'. The problem on Windows is that path uses '\' but git show seems to want a posix path. Git show therefore doesn't find the file and returns an empty output, leading presubmit to think all the deps are new.
,
May 25 2017
,
May 25 2017
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/fc1c6f4c1fac4de7647da83425f4398dde6e77ca commit fc1c6f4c1fac4de7647da83425f4398dde6e77ca Author: Pierre-Antoine Manzagol <manzagop@chromium.org> Date: Wed May 31 21:54:17 2017 Correct Git show's path format on Windows _CalculateAddedDeps calls into depot tools' scm.py GetOldContents to compare previous and current versions of the DEPS file. GetOldContents attempts to 'git show <sha>:<path>'. The problem on Windows is that path uses '\' but git show seems to want a posix path. Git show therefore doesn't find the file and returns an empty output, leading presubmit to think all the deps are new. Bug:725933 Change-Id: Ifbbfbcba4be466d9be623826818fd191bd2ca525 Reviewed-on: https://chromium-review.googlesource.com/514142 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/fc1c6f4c1fac4de7647da83425f4398dde6e77ca/scm.py [modify] https://crrev.com/fc1c6f4c1fac4de7647da83425f4398dde6e77ca/tests/scm_unittest.py
,
Jun 30 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by manzagop@chromium.org
, May 24 2017