New issue
Advanced search Search tips

Issue 725927 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Support non-standard display scale factors

Project Member Reported by khmel@chromium.org, May 24 2017

Issue description

Some devices have non-supported display scale factors,
For example Cave - 1.25. This leads to use of default app icons for ARC apps in few cases. For example in notification view, uninstall dialog.
 

Comment 1 by khmel@chromium.org, May 24 2017

Inner bugs: b/36790645 b/34521325

Comment 2 by khmel@chromium.org, May 24 2017

Labels: M-59

Comment 4 by khmel@chromium.org, May 30 2017

Status: Fixed (was: Started)

Comment 5 by khmel@chromium.org, May 30 2017

Labels: -M-59 M-60

Comment 6 by khmel@chromium.org, May 31 2017

Labels: Merge-Request-60
Status: Started (was: Fixed)
Project Member

Comment 7 by sheriffbot@chromium.org, May 31 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3526ec26b275d2249dc7f381c528dc548ce71d2b

commit 3526ec26b275d2249dc7f381c528dc548ce71d2b
Author: khmel <khmel@chromium.org>
Date: Thu Jun 01 00:22:11 2017

[Merge M60] arg: Support non-standard display scale factors.

This CL makes it possible to use ARC app icons in notification view,
ARC uninstall dialog view and other places.

TEST=Unit test + manually on device.
BUG= 725927 
BUG=b/36790645
BUG=b/34521325
TBR=xiyuan@chromium.org,oshima@chromium.org,msw@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2902153002
Cr-Original-Commit-Position: refs/heads/master@{#475185}
Review-Url: https://codereview.chromium.org/2915963002
Cr-Commit-Position: refs/branch-heads/3112@{#74}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/3526ec26b275d2249dc7f381c528dc548ce71d2b/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/3526ec26b275d2249dc7f381c528dc548ce71d2b/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/3526ec26b275d2249dc7f381c528dc548ce71d2b/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/3526ec26b275d2249dc7f381c528dc548ce71d2b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/3526ec26b275d2249dc7f381c528dc548ce71d2b/ui/gfx/image/image_skia.cc
[modify] https://crrev.com/3526ec26b275d2249dc7f381c528dc548ce71d2b/ui/gfx/image/image_skia.h

Comment 9 by khmel@chromium.org, Jun 1 2017

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment