New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725926 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Recycle resources in OffscreenCanvasFrameDispatcher

Project Member Reported by junov@chromium.org, May 24 2017

Issue description

Texture and mailbox resource generation overhead counts for a large part of the cost of OffscreenCanvas commit overhead. This cost can be reduced by recycling resources.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76d87e592a78e48415d636953de367da57c100bd

commit 76d87e592a78e48415d636953de367da57c100bd
Author: Justin Novosad <junov@chromium.org>
Date: Mon May 29 21:40:38 2017

Refactor OffscreenCanvas Resource tracking

This change refactors OffscreenCanvasFrameDispatcheImpl to make it
track resources locked for the compositor, using a single hash map
instead of one per resource type. This change also allows resources
to by recycled in order to reduce resource allocation ovehead.
In particular, mailbox generation and texture allocation are costly.
This CL does solve mailbox recycling for the GPU-accelerated use case.

Bug:  725926 
Change-Id: I34c3261de63c274c07c99b29529154508f697d32
Reviewed-on: https://chromium-review.googlesource.com/513613
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475384}
[modify] https://crrev.com/76d87e592a78e48415d636953de367da57c100bd/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/76d87e592a78e48415d636953de367da57c100bd/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

Comment 2 by junov@chromium.org, Jun 1 2017

Status: Fixed (was: Assigned)

Sign in to add a comment