New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725906 link

Starred by 1 user
Status: Fixed
Owner:
█ hu...@opera.com
Email to this user bounced
Closed: Jun 2017
Cc:
█ most...@opera.com
michae...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

Allow generation of outdir when enable_extensions=false

Reported by hu...@opera.com, May 24 2017 
Generating a build directory with enable_extensions=false is currently broken.

Here are two downstream configurations that we would like to keep working:

$ gn gen --args='enable_extensions=false' out/
$ gn gen --args='target_os="android" enable_extensions=false' out/

Comment 1 by hu...@opera.com, May 26 2017

Blockedon: 726700
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7a620c87d8df98cbf01a6775c668768d0cd4840

commit f7a620c87d8df98cbf01a6775c668768d0cd4840
Author: hugoh <hugoh@opera.com>
Date: Thu Jun 15 09:00:17 2017

Allow generation of a chromium outdirs when enable_extensions=false

This allows us at Opera to patch chromium a little less before
building a downstream product that doesn't depend on extensions.

At the moment, the 'chrome' target does not compile when
enable_extensions=false - and this is fine since Chrome indeed
needs extensions. But other browser products that use
enable_extensions=false can now generate an outdir without
getting complaints from GN.

BUG= 725906 

TEST=gn gen out/GnTest
TEST=gn gen --args='enable_extensions=false' out/GnTest
TEST=gn gen --args='is_component_build=true' out/GnTest
TEST=gn gen --args='is_component_build=true enable_extensions=false' out/GnTest
TEST=gn gen --args='target_os="android"' out/GnTest
TEST=gn gen --args='target_os="android" enable_extensions=false' out/GnTest
TEST=gn gen --args='target_os="chromeos"' out/GnTest
TEST=gn gen --args='target_os="chromeos" is_component_build=true' out/GnTest

Review-Url: https://codereview.chromium.org/2904443004
Cr-Commit-Position: refs/heads/master@{#479646}

[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/apps/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/chrome/browser/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/chrome/test/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/activity_log/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/alarms/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/app_current_window_internal/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/app_runtime/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/app_window/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/audio/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/bluetooth/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/bluetooth_low_energy/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/bluetooth_socket/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/cast_channel/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/clipboard/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/declarative/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/declarative_content/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/declarative_webrequest/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/diagnostics/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/display_source/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/dns/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/document_scan/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/file_handlers/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/hid/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/idle/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/management/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/messaging/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/metrics_private/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/mime_handler_private/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/networking_config/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/networking_private/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/power/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/printer_provider/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/printer_provider_internal/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/runtime/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/serial/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/socket/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/sockets_tcp/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/sockets_tcp_server/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/sockets_udp/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/storage/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/system_cpu/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/system_display/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/system_info/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/system_memory/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/system_network/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/system_storage/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/test/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/usb/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/virtual_keyboard/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/virtual_keyboard_private/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/vpn_provider/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/web_request/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/api/webcam_private/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/app_window/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/guest_view/web_view/web_ui/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/install/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/kiosk/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/updater/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/browser/value_store/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/common/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/components/javascript_dialog_extensions_client/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/components/native_app_window/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/features/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/shell/common/api/BUILD.gn
[modify] https://crrev.com/f7a620c87d8df98cbf01a6775c668768d0cd4840/extensions/shell/installer/linux/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83c87ba32eea432dfc59a1079ad6218ee230e57

commit f83c87ba32eea432dfc59a1079ad6218ee230e57
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Thu Jun 15 19:32:03 2017

add missing import for enable_extensions

BUG= 733663 , 725906 
TBR=brettw

Change-Id: I2c4b30ac5c93372952f7f3901929afc57bef6572
Reviewed-on: https://chromium-review.googlesource.com/537372
Reviewed-by: Mostyn Bramley-Moore <mostynb@opera.com>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#479784}
[modify] https://crrev.com/f83c87ba32eea432dfc59a1079ad6218ee230e57/extensions/shell/installer/linux/BUILD.gn

Comment 4 by hu...@opera.com, Jun 22 2017

Status: Fixed (was: Started)

Comment 5 by hu...@opera.com, Jun 22 2017

Blockedon: -726700
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02b18b7bde2afa136db8c79fab03943f68ccb5fb

commit 02b18b7bde2afa136db8c79fab03943f68ccb5fb
Author: hugoh <hugoh@opera.com>
Date: Fri Jun 30 08:06:28 2017

Allow outdirs when !enable_extensions and !enable_print_preview

This lets us generate outdirs for builds where enable_extensions
and enable_print_preview are false. This is a configuration that
is used by Opera's TV SDK.

This can be seen as a fixup to https://codereview.chromium.org/2904443004/ .

BUG= 725906 

TEST=gn gen --args='enable_extensions=false enable_print_preview=false' out/GnTest

Review-Url: https://codereview.chromium.org/2958243002
Cr-Commit-Position: refs/heads/master@{#483654}

[modify] https://crrev.com/02b18b7bde2afa136db8c79fab03943f68ccb5fb/chrome/test/BUILD.gn
►

Sign in to add a comment