New issue
Advanced search Search tips

Issue 725903 link

Starred by 3 users
Status: Fixed
Owner:
jfernan...@igalia.com
Closed: May 2017
Cc:
jfernan...@igalia.com
r...@igalia.com
svil...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 79180



Sign in to add a comment

[css-grid] Margin wrong applied to orthogonal item in fixed size track

Project Member Reported by r...@igalia.com, May 24 2017 

Check the attached example, the "margin-right: 25px" is not applied to the item.

If you add "body { overflow: scroll; }" to the example the issue is gone.
So it's some kind of wrong result in the 2nd layout.
bug-orthogonal.html
254 bytes View Download
bug-orthogonal-current.png
1.1 KB View Download
bug-orthogonal-expected.png
1.1 KB View Download

Comment 1 by r...@igalia.com, May 25 2017 

It's even more strange if we test left, top and bottom margin too.
bug-orthogonal-more.html
671 bytes View Download
bug-orthogonal-more.png
16.8 KB View Download

Comment 2 by r...@igalia.com, May 25 2017

Summary: [css-grid] Margin wrong applied to orthogonal item in fixed size track (was: [css-grid] Margin wrong applied to orthogonal item)
It seems this only happens on fixed size tracks.

Comment 3 by jfernan...@igalia.com, May 25 2017 

I figure out the root cause of the issue. 
Under situations when the Grid layout is executed more than once, we indeed clear the item's overrideHeight/Width to make the layout repeatable, but the item may not need to be laid out again. 

When the tracks are auto-sized, we need to layout the item in any case, so that's why the issue is not reproducible.

Comment 4 by r...@igalia.com, May 29 2017

Owner: jfernan...@igalia.com
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/517922/
Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd

commit 958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Mon May 29 23:38:26 2017

[css-grid] Apply flow-aware logic for margins during stretching

We need to consider orthogonality when using the item's logical margin to
compute the available space for stretching.

The issue this CL fixes is only reproducible when the grid layout logic
is executed several times, since probably the item doesn't need to be
laid out again. In such cases, we just get the cached logical margins
but we were not taking orthogonality into account.

Bug:  725903 
Change-Id: Id140723dcb8d2cc835598430cf2556ef17228ec3
Reviewed-on: https://chromium-review.googlesource.com/517922
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#475394}
[modify] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-001.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-002.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-003.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-004.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-005.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-006.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-007.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-008.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-009.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-010.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-011.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-012.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-013.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-014.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-015.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-016.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-001.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-002.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-003.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-004.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-005.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-006.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-007.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-008.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-009.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-010.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-011.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-012.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-013.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-014.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-015.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-016.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-001.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-002.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-003.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-004.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-005.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-006.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-007.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-008.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-009.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-010.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-011.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-012.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-013.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-014.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-015.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-016.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/support/check-layout-th.js
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts-expected.html
[add] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts.html
[modify] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/958dbb23d9fb6ef967f76d9cda0153a6cb05f8cd/third_party/WebKit/Source/core/layout/LayoutGrid.h

Comment 6 by jfernan...@igalia.com, May 30 2017

Status: Fixed (was: Started)
This issue should be FIXED now.

Comment 7 by jfernan...@igalia.com, May 30 2017

Labels: Merge-Request-60
This issue was introduced in r469964, which was part of the 60.0.3107.0 Chrome. 
Perhaps it'd be a good idea to merge this fix in M60.
Project Member

Comment 8 by sheriffbot@chromium.org, May 30 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/988728c3ed9dca2d73563d68afa07585e67b0203

commit 988728c3ed9dca2d73563d68afa07585e67b0203
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Wed May 31 09:06:37 2017

[css-grid] Apply flow-aware logic for margins during stretching

We need to consider orthogonality when using the item's logical margin to
compute the available space for stretching.

The issue this CL fixes is only reproducible when the grid layout logic
is executed several times, since probably the item doesn't need to be
laid out again. In such cases, we just get the cached logical margins
but we were not taking orthogonality into account.

Bug:  725903 
Change-Id: Id140723dcb8d2cc835598430cf2556ef17228ec3
Reviewed-on: https://chromium-review.googlesource.com/517922
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Cr-Original-Commit-Position: refs/heads/master@{#475394}
Review-Url: https://codereview.chromium.org/2919473002 .
Cr-Commit-Position: refs/branch-heads/3112@{#50}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-001.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-002.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-003.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-004.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-005.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-006.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-007.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-008.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-009.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-010.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-011.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-012.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-013.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-014.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-015.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-016.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-001.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-002.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-003.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-004.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-005.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-006.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-007.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-008.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-009.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-010.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-011.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-012.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-013.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-014.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-015.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-016.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-001.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-002.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-003.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-004.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-005.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-006.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-007.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-008.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-009.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-010.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-011.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-012.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-013.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-014.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-015.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-016.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/support/check-layout-th.js
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts-expected.html
[add] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts.html
[modify] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/988728c3ed9dca2d73563d68afa07585e67b0203/third_party/WebKit/Source/core/layout/LayoutGrid.h

Comment 10 by ajha@chromium.org, Jun 1 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3112.10
Verified the merge on 60.0.3112.10 on Windows-10, Mac OS 10.12.4 and Linux Ubuntu 14.04. This is working as intended, hence adding the verified label. Screenshot is attached.
725903.png
63.7 KB View Download
►

Sign in to add a comment