This bug is about the UI support for the feature Mocks: https://docs.google.com/presentation/d/1GIJVHf66kzX7wttEXQn3KrU-MxR5ro59gw7H7yLf5-o/edit Design doc: https://docs.google.com/document/d/1S5qo5rfk_4wsQ3oHLaXdAAHfasJIZ3ERf0hbT1WnoiI/edit#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c92e3ffe214321528fe911957e2926123fc08ef2 commit c92e3ffe214321528fe911957e2926123fc08ef2 Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Thu May 25 10:21:08 2017 [Suggestions] Add flag to guard the Categories UI BUG= 725887 Change-Id: Ife9b11dc44cf2997f7153e130fa9c2cde000fc67 Reviewed-on: https://chromium-review.googlesource.com/513867 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#474619} [modify] https://crrev.com/c92e3ffe214321528fe911957e2926123fc08ef2/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/c92e3ffe214321528fe911957e2926123fc08ef2/chrome/browser/about_flags.cc [modify] https://crrev.com/c92e3ffe214321528fe911957e2926123fc08ef2/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/c92e3ffe214321528fe911957e2926123fc08ef2/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/c92e3ffe214321528fe911957e2926123fc08ef2/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/c92e3ffe214321528fe911957e2926123fc08ef2/chrome/browser/flag_descriptions.h [modify] https://crrev.com/c92e3ffe214321528fe911957e2926123fc08ef2/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88476a9f884788896b7b0a65eb1594187e8f3def commit 88476a9f884788896b7b0a65eb1594187e8f3def Author: Chris Pickel <sfiera@chromium.org> Date: Thu Jun 08 15:45:52 2017 ntp_snippets: disable local categories by feature If kContentSuggestionsCategories is enabled, then we only want to display categories served by the server, so in that case, disable local categories. BUG= 725887 Change-Id: Ibe67824088cb6ca342635054e416a8315c769d79 Reviewed-on: https://chromium-review.googlesource.com/521163 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#477979} [modify] https://crrev.com/88476a9f884788896b7b0a65eb1594187e8f3def/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
Feature cancelled, need to revert the above patches and cleanup code.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de663aecc444da6641e0eec7ea6f767f485dada9 commit de663aecc444da6641e0eec7ea6f767f485dada9 Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Fri Jul 07 12:08:18 2017 Revert "ntp_snippets: disable local categories by feature" This reverts commit 88476a9f884788896b7b0a65eb1594187e8f3def. Reason for revert: Feature cancelled Original change's description: > ntp_snippets: disable local categories by feature > > If kContentSuggestionsCategories is enabled, then we only want to > display categories served by the server, so in that case, disable local > categories. > > BUG= 725887 > > Change-Id: Ibe67824088cb6ca342635054e416a8315c769d79 > Reviewed-on: https://chromium-review.googlesource.com/521163 > Commit-Queue: Chris Pickel <sfiera@chromium.org> > Reviewed-by: Markus Heintz <markusheintz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#477979} Bug: 725887 Change-Id: I0f09876869b36f0465438c756153a9fd1e576fac Reviewed-on: https://chromium-review.googlesource.com/561718 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Markus Heintz <markusheintz@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#484892} [modify] https://crrev.com/de663aecc444da6641e0eec7ea6f767f485dada9/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee4dcaf867b8a64b597070463fe50e0745573646 commit ee4dcaf867b8a64b597070463fe50e0745573646 Author: Nicolas Dossou-gbete <dgn@chromium.org> Date: Fri Jul 07 12:40:00 2017 Revert "[Suggestions] Add flag to guard the Categories UI" This reverts commit c92e3ffe214321528fe911957e2926123fc08ef2. Bug: 725887 Change-Id: I507da712dc10681b15ca2590cadb2cf8735d3e8f Reviewed-on: https://chromium-review.googlesource.com/561719 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#484897} [modify] https://crrev.com/ee4dcaf867b8a64b597070463fe50e0745573646/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/ee4dcaf867b8a64b597070463fe50e0745573646/chrome/browser/about_flags.cc [modify] https://crrev.com/ee4dcaf867b8a64b597070463fe50e0745573646/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/ee4dcaf867b8a64b597070463fe50e0745573646/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/ee4dcaf867b8a64b597070463fe50e0745573646/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/ee4dcaf867b8a64b597070463fe50e0745573646/chrome/browser/flag_descriptions.h
WNF Obsolete is the more appropriate status
Comment 1 by dgn@chromium.org
, May 24 2017