Issue metadata
Sign in to add a comment
|
Regression: Blur text is seen in Chrome webstore/Gmail |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3109.0 OS: Mac 10.12.4 Test-Url: https://chrome.google.com/webstore/category/extensions?utm_source=chrome-ntp-icon What steps will reproduce the problem? (1)Launch chrome >> Navigate to Chrome Webstore and Observe Extensions/Get started/ViewAll text Expected: Text should be seen clearly. Actual: Instead text is seen blur. This is Regression issue. Will provide bisect info seen. Note: Issue is seen only on Mac OS.
,
May 24 2017
Text is also seen blurred on Compose button of gmail.
,
May 24 2017
I am looking into this. Looks like it could be LCD artifacts, but it is strange that this doesn't repo on any other device. Though I have repro'd it as well on chrome canary and it only happens when using GPU rasterization. I've tried pulling a test SkPicture from the site (though pulled from linux machine since it requires chrome built from source) and then drawing it on my mac using our local tools. In these tools it all looks correct. I'm in the processes of building chrome on my mac laptop to confirm that it was the LCD change, but that is going to take a while to build. Will revert the changes before branch if no fix is found.
,
May 24 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/aa13223f54d1f55ba702582f61359f8b43782730 commit aa13223f54d1f55ba702582f61359f8b43782730 Author: Greg Daniel <egdaniel@google.com> Date: Wed May 24 19:52:05 2017 Allow for non opaque colors for src-over lcd fallback case in gpu Since skia is currently requiring the dst to be opaque for lcd draws this change is safe to make in terms of correctly. It will also be faster than the current shader based blending. Bug: chromium:725879 Change-Id: I0c14b80eb5ab819500afc55030df83d5ddbef94a Reviewed-on: https://skia-review.googlesource.com/17840 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/aa13223f54d1f55ba702582f61359f8b43782730/src/gpu/effects/GrPorterDuffXferProcessor.cpp
,
May 24 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/aa13223f54d1f55ba702582f61359f8b43782730 commit aa13223f54d1f55ba702582f61359f8b43782730 Author: Greg Daniel <egdaniel@google.com> Date: Wed May 24 19:52:05 2017 Allow for non opaque colors for src-over lcd fallback case in gpu Since skia is currently requiring the dst to be opaque for lcd draws this change is safe to make in terms of correctly. It will also be faster than the current shader based blending. Bug: chromium:725879 Change-Id: I0c14b80eb5ab819500afc55030df83d5ddbef94a Reviewed-on: https://skia-review.googlesource.com/17840 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/aa13223f54d1f55ba702582f61359f8b43782730/src/gpu/effects/GrPorterDuffXferProcessor.cpp
,
May 24 2017
,
May 25 2017
This seems to be working fine on the latest Mac OS 10.12.4 using canary version: 60.0.3110.0. Hence adding the verified label. Greg@: Please close the issue if there is no further work to be done here.
,
May 25 2017
,
May 25 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
May 25 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jbanavatu@chromium.org
, May 24 2017Labels: -Needs-Bisect hasbisect-per-revision
Owner: egdaniel@chromium.org
Status: Assigned (was: Untriaged)