Issue metadata
Sign in to add a comment
|
Files.app CTRL-N does not open new window with non-US keyboard layout selected
Reported by
realgran...@gmail.com,
May 24 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9334.72.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.140 Safari/537.36 Platform: 9334.72.0 (Official Build) stable-channel cave Steps to reproduce the problem: 1. Choose RU layout 2. Open Files.app 3. Press CTRL-N What is the expected behavior? Open a new files.app window What went wrong? opens a new chrome window Did this work before? Yes Chrome version: 58.0.3029.140 Channel: stable OS Version: 9334.72.0 Flash Version: Shockwave Flash 25.0 r0 May be related to Issue 453348 but this one is reproduced every time
,
Jun 2 2017
,
Jun 2 2017
+Weifang to reproduce and triage
,
Jun 7 2017
+tbuckley@ - I reproduced this behavior on the latest Dev channel. Could you take a look and advise on the right fix?
,
Jul 21 2017
,
Oct 18 2017
,
Nov 17 2017
My guess is that Files.app isn't checking for Ctrl+N in an input method independent way. For a US keyboard layout, Ctrl+N will always trigger an event with e.code == "KeyN" but the character produced (e.key) may differ. It's also possible that somehow Chrome isn't letting Files.app handle the keyboard shortcut. In that case, +afakhry may be able to advise.
,
Feb 23 2018
,
Feb 28 2018
,
Nov 7
,
Nov 18
Weifang, I assume that this bug is OK for me to take over and implement.
,
Nov 19
Yes, thanks joelhockey@!
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4fa1fc7787df456bdefac279bfa65802f311a03 commit d4fa1fc7787df456bdefac279bfa65802f311a03 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Nov 22 04:51:10 2018 Use KeyboardEvent.keyCode in addition to KeyboardEvent.key for shortcut handling to work with RU keyboard. Added tests to verify expected behavior for US, DV, RU keyboards. Bug: 725869 Change-Id: I9b81f0bca5fed786fa5b152e25b646cd188ca2a4 Reviewed-on: https://chromium-review.googlesource.com/c/1341444 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#610303} [modify] https://crrev.com/d4fa1fc7787df456bdefac279bfa65802f311a03/chrome/test/data/webui/command_test.html [modify] https://crrev.com/d4fa1fc7787df456bdefac279bfa65802f311a03/ui/webui/resources/js/cr/ui/command.js
,
Nov 22
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rjahagir@chromium.org
, Jun 2 2017