New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725861 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Improve enterprise icon on IME menu

Project Member Reported by pmarko@chromium.org, May 24 2017

Issue description

Followup to  bug 373324  reported by tdanderson:

Just noticed this change in the codebase while doing some cleanup. In https://codereview.chromium.org/2652793003/ you have added the enterprise-controlled icon to the IME detailed view of the system menu. However note that it is user-configurable whether the IME menu is shown in the system menu or as a standalone menu (known as the "opt-in IME menu"). If the user opts to show the standalone menu, you will not see the enterprise icon/message since it uses a different title row than the detailed IME menu.

To see this standalone menu, go to chrome://settings > Advanced > Language and input settings > Scroll down to the very bottom since the button isn't immediately visible > select "Show input options in the shelf"

+xiangye@google.com and +azurewei@google.com who owns this standalone IME menu, and +jamescook@google.com as FYI.

FYI the engineering work involved will likely be very similar to what is needed here: https://bugs.chromium.org/p/chromium/issues/detail?id=646698#c45 (a row containing an icon + message in the VPN submenu).

 

Comment 1 by pmarko@chromium.org, May 24 2017

Suggestion by tdanderson:

An alternate implementation idea: you could prepend the icon and message to the top of the IME list in IMEListView (similar to how the keyboard status row is prepended, see ImeListView::Update() as an example). The code in IMEListView is shared between both IME menus, so your message will therefore be visible in both. The other advantage is that the enterprise-controlled message will not be hidden behind a tooltip as it is today (making it inaccessible with touch input). This also maintains consistency elsewhere in the system menu; header rows are only really meant to contain clickable buttons.

Components: UI>Shell>StatusArea UI>Input>Text>IME
Labels: OS-Chrome

Sign in to add a comment