Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 2 users
Status: Fixed
Owner:
Closed: May 29
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment
authpolicy build failure when USE=-cros-debug (broke all release builders)
Project Member Reported by hychao@chromium.org, May 24 Back to list
https://uberchromegw.corp.google.com/i/chromeos/builders/eve-release/builds/572

authpolicy-0.0.1-r382: FAILED: obj/authpolicy/libauthpolicy.authpolicy_flags.o 
authpolicy-0.0.1-r382: x86_64-cros-linux-gnu-clang++ -MMD -MF obj/authpolicy/libauthpolicy.authpolicy_flags.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iobj/authpolicy/libauthpolicy.gen/include -Igen/include -I/mnt/host/source/src/platform2 -I/mnt/host/source/src/platform -I/build/eve/usr/include -Igen -Wunused -Wshadow -Wextra -Wall -Wno-psabi -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/eve -DUSE_RTTI_FOR_TYPE_TAGS -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/eve/usr/include/chromeos -I/build/eve/usr/include/base-395517 -I/build/eve/usr/include/glib-2.0 -I/build/eve/usr/lib64/glib-2.0/include -I/build/eve/usr/include/nss -I/build/eve/usr/include/nspr -I/build/eve/usr/include/dbus-1.0 -I/build/eve/usr/lib64/dbus-1.0/include -fPIE -std=gnu++11 -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -clang-syntax -clang-syntax -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags.cc -o obj/authpolicy/libauthpolicy.authpolicy_flags.o
authpolicy-0.0.1-r382: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags.cc:62:25: error: variable 'bool_value' is uninitialized when used here [-Werror,-Wuninitialized]
authpolicy-0.0.1-r382:       (flags->*setter_)(bool_value);
authpolicy-0.0.1-r382:                         ^~~~~~~~~~
authpolicy-0.0.1-r382: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_flags.cc:60:22: note: initialize the variable 'bool_value' to silence this warning
authpolicy-0.0.1-r382:       bool bool_value;
authpolicy-0.0.1-r382:                      ^
authpolicy-0.0.1-r382:                       = false
authpolicy-0.0.1-r382: 1 error generated.
 
Project Member Comment 1 by bugdroid1@chromium.org, May 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5e88750f333a5ccd6839503a152f8965fd9276b1

commit 5e88750f333a5ccd6839503a152f8965fd9276b1
Author: Hsinyu Chao <hychao@chromium.org>
Date: Wed May 24 10:54:08 2017

Revert "authpolicy: Add debug flags for logging, turn off by default"

This reverts commit d6e9f81b6f9ca641202c250f1761ea1f4122c0e1.

Revert to fix build package failure.

BUG= chromium:725856 
TEST=None

Change-Id: Ic757dee4a5bfb9ffdfae004191884688062c469a
Reviewed-on: https://chromium-review.googlesource.com/513396
Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org>
Commit-Queue: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>

[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/process_executor.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/tgt_manager.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/user_policy_encoder.cc
[delete] https://crrev.com/b0d07c0e85b99df851a4f4f469d4df0e471b977b/authpolicy/authpolicy_flags.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/device_policy_encoder.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/preg_policy_encoder.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/process_executor.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/jail_helper.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/user_policy_encoder.h
[add] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/log_level.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/path_service.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/path_service.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/device_policy_encoder.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/jail_helper.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/samba_interface.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/authpolicy_parser_main.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/samba_helper.cc
[delete] https://crrev.com/b0d07c0e85b99df851a4f4f469d4df0e471b977b/authpolicy/authpolicy_flags_unittest.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/samba_helper.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/authpolicy.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/preg_policy_encoder.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/proto/authpolicy_containers.proto
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/authpolicy.gyp
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/preg_policy_encoder_unittest.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/policy/device_policy_encoder_unittest.cc
[delete] https://crrev.com/b0d07c0e85b99df851a4f4f469d4df0e471b977b/authpolicy/authpolicy_flags.h
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/tgt_manager.cc
[modify] https://crrev.com/5e88750f333a5ccd6839503a152f8965fd9276b1/authpolicy/samba_interface.h

Cc: tnagel@chromium.org
Status: Assigned
Status: Started
Comment 5 Deleted
Comment 6 Deleted
filed  issue 725931  to help catch this in the CQ
Project Member Comment 8 by bugdroid1@chromium.org, May 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1589f9dff971da411966a43f066a23c9660fdad4

commit 1589f9dff971da411966a43f066a23c9660fdad4
Author: Lutz Justen <ljusten@chromium.org>
Date: Fri May 26 00:15:52 2017

authpolicy: Reland "Add debug flags for logging, turn off by default"

Initializes bool_value and fixes compile errors.

BUG= chromium:725856 
TEST=None

Change-Id: I0bba93ab8d6cc2f51c6f00e200ee0bb1a9d0b712
Reviewed-on: https://chromium-review.googlesource.com/514086
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/process_executor.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/tgt_manager.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/user_policy_encoder.cc
[add] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/authpolicy_flags.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/device_policy_encoder.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/preg_policy_encoder.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/process_executor.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/jail_helper.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/user_policy_encoder.h
[delete] https://crrev.com/0dd418890c526eb1c0e03e889cfc3d81bceb5ede/authpolicy/log_level.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/path_service.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/path_service.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/device_policy_encoder.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/jail_helper.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/samba_interface.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/authpolicy_parser_main.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/samba_helper.cc
[add] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/authpolicy_flags_unittest.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/samba_helper.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/authpolicy.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/preg_policy_encoder.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/proto/authpolicy_containers.proto
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/authpolicy.gyp
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/preg_policy_encoder_unittest.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/policy/device_policy_encoder_unittest.cc
[add] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/authpolicy_flags.h
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/tgt_manager.cc
[modify] https://crrev.com/1589f9dff971da411966a43f066a23c9660fdad4/authpolicy/samba_interface.h

Status: Fixed
Labels: VerifyIn-61
Sign in to add a comment