Findbugs error in VrShellDelegate. |
|||||||||
Issue descriptionI just tried to do a local Findbugs build of chrome_public, trying to confirm that I had fixed a Findbugs problem of mine, and got the following Findbugs error: FindBugs reported the following issues: BC_UNCONFIRMED_CAST: Unchecked/unconfirmed cast In class org.chromium.chrome.browser.vr_shell.VrShellDelegate In method org.chromium.chrome.browser.vr_shell.VrShellDelegate.onActivityStateChange(Activity, int) At VrShellDelegate.java:[line 467] ******************************************************************************** This stops the build. I am not sure why this isn't happening on the bots. Looking at git blame this seems to be mthiesse@'s code.
,
May 24 2017
Agreed, it is just a slightly hidden check. The strange thing is that Findbugs on the bots seems to get this right, so it could possibly be something wrong with the setup of Findbugs on my development machine. I am also seeing a similar problem in one other place; and have asked the Clank team for suggestions for what could be wrong with my setup, but have yet to receive any replies.
,
May 24 2017
Yes sure. @aberent, how do do a local Findbugs build for testing?
,
May 24 2017
Add run_findbugs = true to your GN arguments.
,
May 24 2017
,
May 24 2017
I can't repro this locally. Spoke to aberent@ offline and he'll look into the possibility of something being wrong with his setup. Ignoring until then.
,
Jun 6 2017
,
Jun 20 2017
aberent: Can you reproduce? If not, can we close?
,
Aug 17 2017
I am having problems running findbugs for other reasons at the moment, see issue 755685. I think the original problem is fixed, but want a successful run to be sure. I will retest once issue 755685 is fixed.
,
Aug 17 2017
I'm fixing this as part of 755685.
,
Aug 21 2017
Awesome. Thanks!
,
Apr 17 2018
Issue 755685 was fixed. Closing this one as well. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mthiesse@chromium.org
, May 24 2017