New issue
Advanced search Search tips

Issue 725840 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 767930



Sign in to add a comment

cc_perftest is failing on Nexus 6 & nexus 7

Project Member Reported by nedngu...@google.com, May 24 2017

Issue description

Logs

Nexus 6: https://chromium-swarm.appspot.com/task?id=36508d0f493d8810&refresh=10&show_raw=1
Nexus 7: https://chromium-swarm.appspot.com/task?id=3650ed2131438110&refresh=10&show_raw=1

C  596.466s Main  [  FAILED  ] SurfaceAggregatorPerfTest.FewSurfaces (CRASHED)
C  596.466s Main  [  FAILED  ] SurfaceAggregatorPerfTest.FewSurfacesAggregateDamaged (CRASHED)
C  596.466s Main  [  FAILED  ] SurfaceAggregatorPerfTest.FewSurfacesDamageCalc (CRASHED)
C  596.466s Main  [  FAILED  ] SurfaceAggregatorPerfTest.ManySurfacesOpaque (CRASHED)
C  596.467s Main  [  FAILED  ] SurfaceAggregatorPerfTest.ManySurfacesOpaqueDamageCalc (CRASHED)
C  596.467s Main  [  FAILED  ] SurfaceAggregatorPerfTest.ManySurfacesTransparent (CRASHED)
C  596.467s Main  [  FAILED  ] SurfaceAggregatorPerfTest.ManySurfacesTransparentDamageCalc (CRASHED)


I will disable these tests for now
 
For the record: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/52 is the first build in which those tests crash.
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf9bd2b9e7713034d798e6aed304124d9a694fd

commit 5cf9bd2b9e7713034d798e6aed304124d9a694fd
Author: nednguyen <nednguyen@google.com>
Date: Wed May 24 14:16:39 2017

Revert of Enforce constant size and device scale factor for surfaces (patchset #16 id:800001 of https://codereview.chromium.org/2848223003/ )

Reason for revert:
Suspect this breaks SurfaceAggregatorPerfTest

BUG= 725840 

Original issue's description:
> Enforce constant size and device scale factor for surfaces
>
> Surfaces are expected to have constant size and device scale factor but
> we don't enforce that. This CL requires a valid SurfaceInfo to be
> provided at the time of constructing a surface, and all frames that don't
> match the SurfaceInfo will be skipped.
>
> TBR=sadrul@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2848223003
> Cr-Commit-Position: refs/heads/master@{#474050}
> Committed: https://chromium.googlesource.com/chromium/src/+/5ba3188fa05666ae8d6031706c0963532f9d1457

TBR=fsamuel@chromium.org,danakj@chromium.org,piman@chromium.org,boliu@chromium.org,sadrul@chromium.org,samans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2905523003
Cr-Commit-Position: refs/heads/master@{#474280}

[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/android_webview/browser/hardware_renderer.h
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/compositor_frame_sink_support.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/compositor_frame_sink_support.h
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/display_unittest.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/surface.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/surface.h
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/surface_aggregator_unittest.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/surface_manager.h
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/surfaces/surface_unittest.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/test/compositor_frame_helpers.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/components/viz/frame_sinks/gpu_compositor_frame_sink.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/content/renderer/android/synchronous_compositor_frame_sink.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/content/renderer/android/synchronous_compositor_frame_sink.h
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/ui/aura/local/compositor_frame_sink_local.cc
[modify] https://crrev.com/5cf9bd2b9e7713034d798e6aed304124d9a694fd/ui/aura/local/compositor_frame_sink_local.h

Comment 3 by enne@chromium.org, May 24 2017

Is there no information about what's crashing or the callstack?
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046

commit cf887b6f97e0762a83e1e054a9d4aeb14fa0f046
Author: samans <samans@chromium.org>
Date: Wed May 24 18:14:29 2017

Reland "Enforce constant size and device scale factor for surfaces" with fixes

The original CL(crrev.com/2848223003) surfaced two problems that this CL
fixes:
- SurfaceAggregatorPerfTest sends frames with zero size and device scale
factor
- SurfacesInstance does not properly allocate new LocalSurfaceIds.

TBR=piman@chromium.org,boliu@chromium.org,sadrul@chromium.org
BUG= 725838 , 725840 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2900303002
Cr-Commit-Position: refs/heads/master@{#474357}

[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/hardware_renderer.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/compositor_frame_sink_support.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/compositor_frame_sink_support.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/display_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_aggregator_perftest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_aggregator_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_manager.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/test/compositor_frame_helpers.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/components/viz/frame_sinks/gpu_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/renderer/android/synchronous_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/renderer/android/synchronous_compositor_frame_sink.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/ui/aura/local/compositor_frame_sink_local.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/ui/aura/local/compositor_frame_sink_local.h

Project Member

Comment 5 by sheriffbot@chromium.org, Jul 14 2017

Labels: Hotlist-Google

Comment 6 by enne@chromium.org, Sep 22 2017

Blockedon: 767930
Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 24

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
No longer running: https://chromium-review.googlesource.com/c/chromium/src/+/1021653

Sign in to add a comment