New issue
Advanced search Search tips

Issue 725838 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyAtOnce" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 24 2017

Issue description

"org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyAtOnce" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWwsSBUZsYWtlIlBvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQXdDb250ZW50c1Rlc3QjdGVzdENyZWF0ZUxvYWREZXN0cm95TWFueUF0T25jZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
The log is not helpful:
===========
I  117.836s run_tests_on_device(008b0b2680d0c92b)  detected failure in org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyAtOnce. raw output:
I  117.837s TimeoutThread-1-for-run_tests_on_device(00b9305e25debad2)  [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00b9305e25debad2 shell '( ( dumpsys window windows )>/data/local/tmp/temp_file-47e5e81904ce9 );echo %$?'
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_STATUS: numtests=1
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_STATUS: stream=
I  117.839s run_tests_on_device(008b0b2680d0c92b)    org.chromium.android_webview.test.AwContentsTest:
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_STATUS: test=testCreateLoadDestroyManyAtOnce
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_STATUS: class=org.chromium.android_webview.test.AwContentsTest
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_STATUS: current=1
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_STATUS_CODE: 1
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_RESULT: shortMsg=Native crash
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_RESULT: longMsg=Native crash: Aborted
I  117.839s run_tests_on_device(008b0b2680d0c92b)    INSTRUMENTATION_CODE: 0
=============
The test was not touched recently.
I am disabling the test.
Owner: vitaliii@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Sheriff-Chromium
Owner: boliu@chromium.org
Assigning the bug to boliu@ as an OWNER of android_webview/ and an author of the test.

The CL to disable the test is https://codereview.chromium.org/2899133003.
Cc: ntfschr@chromium.org
+ cc ntfschr@ as the last one to touch the test.
Project Member

Comment 8 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1711fc89b7d02a4e7aba2a66cb7f291d08a8fac

commit b1711fc89b7d02a4e7aba2a66cb7f291d08a8fac
Author: vitaliii <vitaliii@chromium.org>
Date: Wed May 24 13:21:12 2017

Disable AwContentsTest#testCreateLoadDestroyManyAtOnce because flaky.

TBR=boliu@chromium.org

BUG= 725838 

Review-Url: https://codereview.chromium.org/2899133003
Cr-Commit-Position: refs/heads/master@{#474272}

[modify] https://crrev.com/b1711fc89b7d02a4e7aba2a66cb7f291d08a8fac/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Comment 9 by boliu@chromium.org, May 24 2017

Cc: samans@chromium.org
The CL that added the DCHECk has been reverted: https://codereview.chromium.org/2905523003/

samans@: note apparently that DCHECK doesn't always hold. So make sure this is fixed as well before relanding.

It's important to keep this test running. Reverting the revert
Project Member

Comment 10 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74c84c6d1a2d21f16fb555cb084abb8c63a858dc

commit 74c84c6d1a2d21f16fb555cb084abb8c63a858dc
Author: boliu <boliu@chromium.org>
Date: Wed May 24 16:19:08 2017

Revert of Disable AwContentsTest#testCreateLoadDestroyManyAtOnce because flaky. (patchset #1 id:1 of https://codereview.chromium.org/2899133003/ )

Reason for revert:
CL that caused DCHECK has been reverted. See bug.

Original issue's description:
> Disable AwContentsTest#testCreateLoadDestroyManyAtOnce because flaky.
>
> TBR=boliu@chromium.org
>
> BUG= 725838 
>
> Review-Url: https://codereview.chromium.org/2899133003
> Cr-Commit-Position: refs/heads/master@{#474272}
> Committed: https://chromium.googlesource.com/chromium/src/+/b1711fc89b7d02a4e7aba2a66cb7f291d08a8fac

TBR=vitaliii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
BUG= 725838 

Review-Url: https://codereview.chromium.org/2900243003
Cr-Commit-Position: refs/heads/master@{#474317}

[modify] https://crrev.com/74c84c6d1a2d21f16fb555cb084abb8c63a858dc/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Comment 11 by boliu@chromium.org, May 24 2017

Status: Fixed (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046

commit cf887b6f97e0762a83e1e054a9d4aeb14fa0f046
Author: samans <samans@chromium.org>
Date: Wed May 24 18:14:29 2017

Reland "Enforce constant size and device scale factor for surfaces" with fixes

The original CL(crrev.com/2848223003) surfaced two problems that this CL
fixes:
- SurfaceAggregatorPerfTest sends frames with zero size and device scale
factor
- SurfacesInstance does not properly allocate new LocalSurfaceIds.

TBR=piman@chromium.org,boliu@chromium.org,sadrul@chromium.org
BUG= 725838 , 725840 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2900303002
Cr-Commit-Position: refs/heads/master@{#474357}

[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/hardware_renderer.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/compositor_frame_sink_support.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/compositor_frame_sink_support.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/direct_compositor_frame_sink_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/display_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_aggregator_perftest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_aggregator_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_manager.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/surfaces/surface_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/test/compositor_frame_helpers.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/components/viz/frame_sinks/gpu_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/renderer/android/synchronous_compositor_frame_sink.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/content/renderer/android/synchronous_compositor_frame_sink.h
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/ui/aura/local/compositor_frame_sink_local.cc
[modify] https://crrev.com/cf887b6f97e0762a83e1e054a9d4aeb14fa0f046/ui/aura/local/compositor_frame_sink_local.h

Sign in to add a comment