New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725833 link

Starred by 1 user
Status: Started
Owner:
j...@chromium.org
Cc:
j...@chromium.org
flyboy@chromium.org
rauch+monorail-auto@google.com
█ orodley+autocc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Make currently served Xref revision visible in the UI

Project Member Reported by emso@chromium.org, May 24 2017 
Before the Git integration Xrefs and files were served from a joint tar ball and the revision of that tar ball was available via a file in the root of the repo shown in code search. With the change to direct access from Git together with layered repos to accommodate DEPS, Xrefs and files match different revisions and the previously used revision file is gone.

Comment 1 by emso@chromium.org, Nov 2 2017

Owner: ----
Status: Available (was: Assigned)

Comment 2 by flyboy@chromium.org, Jan 24 2018 

FYI, here's how internal CS does it.  If we could do something similar that would be best.

https://screenshot.googleplex.com/06LPC6xSgs5

Comment 3 by j...@chromium.org, Apr 9 2018

Owner: j...@chromium.org
Status: Assigned (was: Available)

Comment 4 by j...@chromium.org, Apr 19 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/28bdb7154fca6c91a5e553125c9c8c960e117450

commit 28bdb7154fca6c91a5e553125c9c8c960e117450
Author: Joey Scarr <jsca@google.com>
Date: Tue May 15 04:55:24 2018

Pass the commit hash as well as the commit position to Kythe.

Bug: 725833
Change-Id: I533f87e92d6271e952036b6e8b9e2ea964334df9
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/1039113
Commit-Queue: Joey Scarr <jsca@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipe_modules/codesearch/api.py
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_win_delete_generated_files_fail.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_with_revision.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win_with_revision.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipe_modules/codesearch/tests/create_and_upload_kythe_index_pack.expected/basic_without_kythe_root.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_with_revision.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipe_modules/codesearch/tests/create_and_upload_kythe_index_pack.expected/basic_without_got_revision_cp.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipe_modules/codesearch/tests/create_and_upload_kythe_index_pack.expected/basic.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_android_with_revision.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win_delete_generated_files_fail.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos_translation_unit_fail.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_win_test_basic.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_win.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_chromiumos.json
[modify] https://crrev.com/28bdb7154fca6c91a5e553125c9c8c960e117450/scripts/slave/recipe_modules/codesearch/examples/full.expected/codesearch_gen_chromium_linux_test_basic.json
►

Sign in to add a comment