New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725819 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature

Blocking:
issue 722335



Sign in to add a comment

RemoveMac audio input restart mechanism

Project Member Reported by grunell@chromium.org, May 24 2017

Issue description

Reasons:

* On output it was removed when the deferred start at suspend/resume was added.
* We don't have stats that shows it helps.
* With the new ended event ( issue 722335 ), the application can make the decision to restart or take any other measures.
* It can allow shorter wait before firing the ended event.

 
Blocking: 722335
Cc: dalecur...@chromium.org
Hmm, don't even remember that we had this :o
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baab05023fbea8af8e626c78899abd87834b70b3

commit baab05023fbea8af8e626c78899abd87834b70b3
Author: grunell <grunell@chromium.org>
Date: Wed May 24 19:01:53 2017

Remove Mac input audio restart mechanism.

Reduce the time until checking startup success from 8 to 5 seconds.

Also only set an atomic variable once instead of at every callback.

BUG= 725819 , 549021 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2896423003
Cr-Commit-Position: refs/heads/master@{#474378}

[modify] https://crrev.com/baab05023fbea8af8e626c78899abd87834b70b3/media/audio/mac/audio_low_latency_input_mac.cc
[modify] https://crrev.com/baab05023fbea8af8e626c78899abd87834b70b3/media/audio/mac/audio_low_latency_input_mac.h
[modify] https://crrev.com/baab05023fbea8af8e626c78899abd87834b70b3/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment