New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725789 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Add TRACE_EVENT for virtual keyboard profiling

Project Member Reported by oka@chromium.org, May 24 2017

Issue description

I think the following functions in KeyboardController are good places to add TRACE_EVENT. 
- ShowKeyboardInternal
- HideKeyboard
- OnTextInputStateChanged

How to add: http://www.chromium.org/developers/how-tos/trace-event-profiling-tool/tracing-event-instrumentation

 

Comment 1 by oka@chromium.org, May 24 2017

Summary: Add TRACE_EVENT for virtual keyboard profiling (was: Add TRACE_EVENT for virtual keyboard)

Comment 2 by blakeo@chromium.org, May 24 2017

Owner: blakeo@chromium.org

Comment 3 by blakeo@chromium.org, May 24 2017

Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a660800ddf7f8d41da872743d5ea5044fd2fb0

commit 62a660800ddf7f8d41da872743d5ea5044fd2fb0
Author: blakeo <blakeo@chromium.org>
Date: Mon Jun 12 02:03:41 2017

Add TRACE_EVENT markers to various keyboard functions

Adds the following under the "vk" trace marker group:
- ShowKeyboardInternal
- ShowKeyboardContainerWindow
- ShowKeyboardContainer
- KeyboardLayoutSetChildBounds
- OnTextInputStateChanged
- HideKeyboard
- ReloadKeyboardIfNeeded
- EnsureCaretInWorkArea
- MoveKeyboardToDisplay
- MoveKeyboardToTouchableDisplay
- MoveKeyboardToDisplayInternal
- LoadContents

BUG= 725789 

Review-Url: https://codereview.chromium.org/2923493002
Cr-Commit-Position: refs/heads/master@{#478539}

[modify] https://crrev.com/62a660800ddf7f8d41da872743d5ea5044fd2fb0/ash/virtual_keyboard_controller.cc
[modify] https://crrev.com/62a660800ddf7f8d41da872743d5ea5044fd2fb0/ui/keyboard/content/keyboard_ui_content.cc
[modify] https://crrev.com/62a660800ddf7f8d41da872743d5ea5044fd2fb0/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/62a660800ddf7f8d41da872743d5ea5044fd2fb0/ui/keyboard/keyboard_layout_manager.cc
[modify] https://crrev.com/62a660800ddf7f8d41da872743d5ea5044fd2fb0/ui/keyboard/keyboard_ui.cc

Comment 5 by blakeo@chromium.org, Jun 15 2017

Labels: -Type-Bug Type-Task
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment