MD Bookmarks should show toasts to confirm subtle actions (cut/copy/paste) and provide a surface for exposing undo functionality.
Marking as P2 since we want this for launch
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/338bf607d38c8a0ace9dd2e0480cad386af2dc4e commit 338bf607d38c8a0ace9dd2e0480cad386af2dc4e Author: calamity <calamity@chromium.org> Date: Tue May 30 02:52:11 2017 Roll Polymer to 1.9.1. BUG= 725786 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902913002 Cr-Commit-Position: refs/heads/master@{#475408} [modify] https://crrev.com/338bf607d38c8a0ace9dd2e0480cad386af2dc4e/third_party/polymer/README.chromium [modify] https://crrev.com/338bf607d38c8a0ace9dd2e0480cad386af2dc4e/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/338bf607d38c8a0ace9dd2e0480cad386af2dc4e/third_party/polymer/v1_0/components-chromium/polymer/bower.json [modify] https://crrev.com/338bf607d38c8a0ace9dd2e0480cad386af2dc4e/third_party/polymer/v1_0/components-chromium/polymer/polymer-extracted.js [modify] https://crrev.com/338bf607d38c8a0ace9dd2e0480cad386af2dc4e/third_party/polymer/v1_0/components-chromium/polymer/polymer-micro-extracted.js [modify] https://crrev.com/338bf607d38c8a0ace9dd2e0480cad386af2dc4e/third_party/polymer/v1_0/components-chromium/polymer/polymer-mini-extracted.js [modify] https://crrev.com/338bf607d38c8a0ace9dd2e0480cad386af2dc4e/third_party/polymer/v1_0/components_summary.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efe47735cb33458311b6d71a3ff47ff65f4200e8 commit efe47735cb33458311b6d71a3ff47ff65f4200e8 Author: calamity <calamity@chromium.org> Date: Wed Jun 07 06:44:58 2017 [MD Bookmarks] Add toasts. This CL adds a bookmarks-toast-manager element which shows toasts for the bookmark manager. Toasts currently show for item deletion, copying urls, and sorting a folder. An undo button may also be shown in the toast. BUG= 725786 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2898303004 Cr-Commit-Position: refs/heads/master@{#477564} [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/app/bookmarks_strings.grdp [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/browser_resources.grd [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/resources/md_bookmarks/app.html [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [add] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/resources/md_bookmarks/toast_manager.html [add] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/resources/md_bookmarks/toast_manager.js [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/resources/md_bookmarks/toolbar.js [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [add] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/ui/webui/plural_string_handler.cc [add] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/browser/ui/webui/plural_string_handler.h [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/test/data/webui/md_bookmarks/command_manager_test.js [modify] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [add] https://crrev.com/efe47735cb33458311b6d71a3ff47ff65f4200e8/chrome/test/data/webui/md_bookmarks/toast_manager_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0917640f381ceb2e2822f9f697bf62447ad4034 commit e0917640f381ceb2e2822f9f697bf62447ad4034 Author: calamity <calamity@chromium.org> Date: Fri Jun 09 07:34:35 2017 [MD Bookmarks] Support elision of bookmark names in the bookmark toast. This CL makes the translated string in the bookmark toast for deletion collapse bookmark names when the bookmark name is too long, without affecting the prior or subsequent parts of the string BUG= 725786 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2917003003 Cr-Commit-Position: refs/heads/master@{#478227} [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/chrome/app/bookmarks_strings.grdp [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/chrome/browser/resources/md_bookmarks/toast_manager.html [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/chrome/browser/resources/md_bookmarks/toast_manager.js [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/chrome/test/data/webui/load_time_data_browsertest.js [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/ui/file_manager/file_manager/background/js/device_handler_unittest.html [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/ui/file_manager/file_manager/background/js/file_operation_handler_unittest.html [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/ui/file_manager/file_manager/foreground/js/progress_center_item_group_unittest.html [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/ui/webui/resources/html/load_time_data.html [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/ui/webui/resources/js/compiled_resources2.gyp [modify] https://crrev.com/e0917640f381ceb2e2822f9f697bf62447ad4034/ui/webui/resources/js/load_time_data.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12a52a35a4bfa982e7fb1c320d16c15691141957 commit 12a52a35a4bfa982e7fb1c320d16c15691141957 Author: calamity <calamity@chromium.org> Date: Mon Jun 19 05:30:07 2017 [MD Bookmarks] Refactor window timer mocking. This CL adds TimerProxy which allows elements to mock out setTimeout and clearTimeout for testing purposes in a nicer way. BUG= 725786 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2926763005 Cr-Commit-Position: refs/heads/master@{#480354} [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/browser_resources.grd [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/resources/md_bookmarks/dnd_manager.html [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/resources/md_bookmarks/dnd_manager.js [add] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/resources/md_bookmarks/timer_proxy.html [add] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/resources/md_bookmarks/timer_proxy.js [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/resources/md_bookmarks/toast_manager.js [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/test/data/webui/md_bookmarks/test_store.js [add] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/test/data/webui/md_bookmarks/test_timer_proxy.js [modify] https://crrev.com/12a52a35a4bfa982e7fb1c320d16c15691141957/chrome/test/data/webui/md_bookmarks/toast_manager_test.js
We have all the toasts we plan to add at this stage. Closing this bug accordingly.
Comment 1 by tsergeant@chromium.org
, May 24 2017Summary: [MD Bookmarks] Add toasts (was: [MD Bookmarks[ Add toasts)