New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725761 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Bookmarks] Singleton Tab behavior not present

Project Member Reported by calamity@chromium.org, May 24 2017

Issue description

Pressing Ctrl+Shift+O twice should not open the bookmark manager twice. There should only be one bookmark manager, that gets refocused, as is the case with the old bookmark manager.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/870ec553a786c0f19d6785a4333fa7a6dc2885c0

commit 870ec553a786c0f19d6785a4333fa7a6dc2885c0
Author: calamity <calamity@chromium.org>
Date: Mon May 29 05:14:27 2017

[MD Bookmarks] Fix singleton tab behavior.

This CL fixes an issue where MD Bookmarks would not focus an existing
tab when the bookmark manager was launched a second time. This was
happening because the query of the URL was being used in the deduping
process, so calling a function which sets IGNORE_AND_NAVIGATE fixes this.

It also fixes an issue where repeatedly pressing the bookmark manager
shortcut would repeatedly refresh the page because the specified URL
is chrome://bookmarks but the redirected URL is chrome://bookmarks/?id=1.

BUG= 725761 

Review-Url: https://codereview.chromium.org/2899223002
Cr-Commit-Position: refs/heads/master@{#475290}

[modify] https://crrev.com/870ec553a786c0f19d6785a4333fa7a6dc2885c0/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/870ec553a786c0f19d6785a4333fa7a6dc2885c0/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
[modify] https://crrev.com/870ec553a786c0f19d6785a4333fa7a6dc2885c0/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/870ec553a786c0f19d6785a4333fa7a6dc2885c0/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)

Sign in to add a comment