The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d8a6a990e3e22af61d54eb8116c9a33867a6d88

commit 7d8a6a990e3e22af61d54eb8116c9a33867a6d88
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Wed May 24 04:54:09 2017

Pass /NATVIS option if use_lld = false

This is work around for lld.

Bug:  725748 
Change-Id: I5f917767e7a2f39328a306ffa177a29109db85a1
Reviewed-on: https://chromium-review.googlesource.com/511787
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474164}
[modify] https://crrev.com/7d8a6a990e3e22af61d54eb8116c9a33867a6d88/tools/win/DebugVisualizers/BUILD.gn

That option is new to me. What are you using the flag for?

It can tell the debugger to load certain debug visualizers: https://cs.chromium.org/search/?q=file:%5C.natvis+package:%5Echromium$&type=cs and https://blogs.msdn.microsoft.com/vcblog/2015/09/28/debug-visualizers-in-visual-c-2015/

The flag isn't documented for link.exe, but it probably puts a reference to the file mentioned in /natvis:foo.natvis somewhere (either in the pdb or the executable).

I guess that the .natvis file depends on the internal representation of the MSVC toolchain and it is hard to emit compatible files from LLD.

In progress here: https://reviews.llvm.org/D44328

zturner, is this done?

We need to remove the !use_lld checks in the natvis gn file too (and check that it works) ifsomeone wants to make a cl for that.

Hopefully it's done now (as of r328002).  Have to wait and see if it sticks, I had to revert it once.

r328002 was reverted, but I think it's now finally fixed in r328363.

I'm closing this for now, will re-open if it gets reverted again but I'm pretty confident this time that it's going to stick.

Let's keep this open until the fix is rolled in and we've then updated chrome's build files to pass the option in lld builds as well. (See also "blocked on")

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d87bfe70381a444b37edfce46bd7aca0077756ec

commit d87bfe70381a444b37edfce46bd7aca0077756ec
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Mar 28 14:02:23 2018

Use /NATVIS when linking with lld too

Support for this was added to lld in r328363, which rolled into Chromium
in #546080.

Bug:  725748 
Change-Id: I65f64295a682a09faca8b4b74ee70dc16ad9ef66
Reviewed-on: https://chromium-review.googlesource.com/983594
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546474}
[modify] https://crrev.com/d87bfe70381a444b37edfce46bd7aca0077756ec/tools/win/DebugVisualizers/BUILD.gn

zturner++; now dangerously close to overflow