New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725740 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 647283



Sign in to add a comment

Record Print Job Success using UMA

Project Member Reported by skau@chromium.org, May 24 2017

Issue description

Record if a print job failed and why.  Also record if a print job succeeded.

Metrics master list:
go/chromeos-cups-metrics
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71cedf9cc39e53e0341dd3dc4b4d7139376dbd48

commit 71cedf9cc39e53e0341dd3dc4b4d7139376dbd48
Author: skau <skau@chromium.org>
Date: Thu May 25 21:13:18 2017

Record print job success and print queue size.

Record two new metrics for Chrome OS.  CUPS.PrintJobsQueued records the
number of print jobs in the queue when a job is started.  CUPS.JobResult
records if a print job failed and why it failed.

BUG= 725740 

Review-Url: https://codereview.chromium.org/2903923003
Cr-Commit-Position: refs/heads/master@{#474805}

[modify] https://crrev.com/71cedf9cc39e53e0341dd3dc4b4d7139376dbd48/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
[modify] https://crrev.com/71cedf9cc39e53e0341dd3dc4b4d7139376dbd48/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/71cedf9cc39e53e0341dd3dc4b4d7139376dbd48/tools/metrics/histograms/histograms.xml

Comment 2 by skau@chromium.org, May 30 2017

Status: Fixed (was: Untriaged)

Comment 3 by skau@chromium.org, Jun 8 2017

Status: Started (was: Fixed)
Values before 61.0.3124.0 are incorrect.  They always record TIMEOUT_CANCEL.

Comment 4 by skau@chromium.org, Jun 9 2017

Labels: M-60

Comment 5 by skau@chromium.org, Jun 9 2017

Original CL landed in 60.3112.0
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8860a660e6bce2f1dde2686ae82efd742ba7ab5a

commit 8860a660e6bce2f1dde2686ae82efd742ba7ab5a
Author: skau <skau@chromium.org>
Date: Mon Jun 12 19:03:55 2017

Record the correct value for print job results.

During refactoring, the wrong value was recorded.  Record the correct value.

BUG= 725740 

Review-Url: https://codereview.chromium.org/2925113004
Cr-Commit-Position: refs/heads/master@{#478705}

[modify] https://crrev.com/8860a660e6bce2f1dde2686ae82efd742ba7ab5a/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc

Comment 7 by skau@chromium.org, Jun 12 2017

Labels: Merge-Request-60
Status: Fixed (was: Started)

Comment 8 by skau@chromium.org, Jun 13 2017

Cc: josa...@chromium.org
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 13 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb3d4cad3721d2df21d30f20c05124e17916ca98

commit eb3d4cad3721d2df21d30f20c05124e17916ca98
Author: Sean Kau <skau@chromium.org>
Date: Thu Jun 15 20:56:11 2017

Record the correct value for print job results.

During refactoring, the wrong value was recorded.  Record the correct value.

BUG= 725740 

Review-Url: https://codereview.chromium.org/2925113004
Cr-Original-Commit-Position: refs/heads/master@{#478705}
Review-Url: https://codereview.chromium.org/2940023003 .
Cr-Commit-Position: refs/branch-heads/3112@{#352}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/eb3d4cad3721d2df21d30f20c05124e17916ca98/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment