New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725739 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 740225

Blocking:
issue 647283



Sign in to add a comment

Record USB information for printers using UMA

Project Member Reported by skau@chromium.org, May 24 2017

Issue description

We need to know what printers users try to configure with their Chromebooks.  Log the vendor id and product id.

Metrics master list:
go/chromeos-cups-metrics
 

Comment 1 by skau@chromium.org, Jul 7 2017

Design doc:
go/bolton-printer-meta

Comment 2 by skau@chromium.org, Jul 7 2017

Blockedon: 740225
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/774b89893d2c2a847e2527e87b545e78a73a7caa

commit 774b89893d2c2a847e2527e87b545e78a73a7caa
Author: Sean Kau <skau@chromium.org>
Date: Sat Jul 08 00:44:32 2017

Add the PrinterEventProto to the UMA proto.

The changes mirror those in the logging system.  Additional info in crbug.com/740225

Bug:  725739 , 740225
Change-Id: I5426da5065b1de2943ec8130e364769d5853affe
Reviewed-on: https://chromium-review.googlesource.com/563607
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485117}
[modify] https://crrev.com/774b89893d2c2a847e2527e87b545e78a73a7caa/components/metrics/proto/BUILD.gn
[modify] https://crrev.com/774b89893d2c2a847e2527e87b545e78a73a7caa/components/metrics/proto/chrome_user_metrics_extension.proto
[add] https://crrev.com/774b89893d2c2a847e2527e87b545e78a73a7caa/components/metrics/proto/printer_event.proto

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d9f08573ffcace0f52f3740bdf1dde28b11cccf

commit 4d9f08573ffcace0f52f3740bdf1dde28b11cccf
Author: Sean Kau <skau@chromium.org>
Date: Sat Jul 29 00:29:16 2017

Extend Printing detector interface to pass metadata.

This changes the PrinterDetector interface to pass through additional
metadata about printers in its API.  This will allow us to do automatic
driver searches in users of the Detection results.

Copy from https://chromium-review.googlesource.com/c/580587

Bug:  744996 ,  742487 ,  725739 
Change-Id: I8dc80224d35620c1614a6afb25e187f1ec00489b
Reviewed-on: https://chromium-review.googlesource.com/590586
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490556}
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/combining_printer_detector.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/combining_printer_detector_unittest.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/printer_detector.h
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/chromeos/printing/usb_printer_detector.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/4d9f08573ffcace0f52f3740bdf1dde28b11cccf/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f7193d347a565c5e3f1e5eef810dab2c5e97402

commit 1f7193d347a565c5e3f1e5eef810dab2c5e97402
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 03 18:29:28 2017

Record USB printers installed automatically.

USB printers are installed automatically if we are sure of the
configuration.  Log these printers with USB attributes and the fact
that they were configured automatically.

Bug:  740270 ,  725739 
Change-Id: I50d4596cbf94fc9de8871cf5c8e02ded75e05681
Reviewed-on: https://chromium-review.googlesource.com/598691
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491800}
[modify] https://crrev.com/1f7193d347a565c5e3f1e5eef810dab2c5e97402/chrome/browser/chromeos/printing/printer_event_tracker.cc
[modify] https://crrev.com/1f7193d347a565c5e3f1e5eef810dab2c5e97402/chrome/browser/chromeos/printing/printer_event_tracker.h
[modify] https://crrev.com/1f7193d347a565c5e3f1e5eef810dab2c5e97402/chrome/browser/chromeos/printing/usb_printer_detector.cc

Comment 6 by skau@chromium.org, Aug 14 2017

Status: Fixed (was: Started)

Comment 7 by skau@chromium.org, Aug 14 2017

Labels: Merge-Request-61
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 14 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6152c1f35f944f591fc282e1d27c74d503212a3f

commit 6152c1f35f944f591fc282e1d27c74d503212a3f
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 17 22:25:33 2017

Extend Printing detector interface to pass metadata.

This changes the PrinterDetector interface to pass through additional
metadata about printers in its API.  This will allow us to do automatic
driver searches in users of the Detection results.

Copy from https://chromium-review.googlesource.com/c/580587

TBR=skau@chromium.org

(cherry picked from commit 4d9f08573ffcace0f52f3740bdf1dde28b11cccf)

Bug:  744996 ,  742487 ,  725739 
Change-Id: I8dc80224d35620c1614a6afb25e187f1ec00489b
Reviewed-on: https://chromium-review.googlesource.com/590586
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490556}
Reviewed-on: https://chromium-review.googlesource.com/619770
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#658}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/combining_printer_detector.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/combining_printer_detector_unittest.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/printer_detector.h
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/chromeos/printing/usb_printer_detector.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/6152c1f35f944f591fc282e1d27c74d503212a3f/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e6352babb20388e7d1ea11f5d377222e3d3695

commit 02e6352babb20388e7d1ea11f5d377222e3d3695
Author: Sean Kau <skau@chromium.org>
Date: Thu Aug 17 22:35:45 2017

Record USB printers installed automatically.

USB printers are installed automatically if we are sure of the
configuration.  Log these printers with USB attributes and the fact
that they were configured automatically.

TBR=skau@chromium.org

(cherry picked from commit 1f7193d347a565c5e3f1e5eef810dab2c5e97402)

Bug:  740270 ,  725739 
Change-Id: I50d4596cbf94fc9de8871cf5c8e02ded75e05681
Reviewed-on: https://chromium-review.googlesource.com/598691
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491800}
Reviewed-on: https://chromium-review.googlesource.com/619756
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#659}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/02e6352babb20388e7d1ea11f5d377222e3d3695/chrome/browser/chromeos/printing/printer_event_tracker.cc
[modify] https://crrev.com/02e6352babb20388e7d1ea11f5d377222e3d3695/chrome/browser/chromeos/printing/printer_event_tracker.h
[modify] https://crrev.com/02e6352babb20388e7d1ea11f5d377222e3d3695/chrome/browser/chromeos/printing/usb_printer_detector.cc

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment