BottomSheet onLayoutChange is too heavy |
|||
Issue descriptionThe layout change listener attached to the bottom sheet's container has become quite complex and CPU intensive and is called on too often. Logic should be added so that views that are not affected are not updated. Events that trigger layout event: - Enter/exit fullscreen. - Screen rotation. - Keyboard show/hide. - Multi-window.
,
Aug 10 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8111080c4aa36450262a1fceaecb5a239a1e00a8 commit 8111080c4aa36450262a1fceaecb5a239a1e00a8 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Aug 24 18:43:03 2017 [Home] Remove layout pass for bottom sheet Since the bottom sheet's content container now consumed the full height of the screen, we no longer need to perform custom sizing. This change removes manual adjustment of layout params in favor of static padding and margin. This change removes the need for one of the relayout requests performed mid-layout. BUG= 725730 Change-Id: I015c02c2b45ba18529f6acbbafbd16eb5e6cb12c Reviewed-on: https://chromium-review.googlesource.com/630479 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#497140} [modify] https://crrev.com/8111080c4aa36450262a1fceaecb5a239a1e00a8/chrome/android/java/res/layout/bottom_control_container.xml [modify] https://crrev.com/8111080c4aa36450262a1fceaecb5a239a1e00a8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/8111080c4aa36450262a1fceaecb5a239a1e00a8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
,
Oct 25
|
|||
►
Sign in to add a comment |
|||
Comment 1 by twelling...@chromium.org
, Jun 20 2017