New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725711 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Submitting CLs based on CQ history

Project Member Reported by nxia@chromium.org, May 23 2017

Issue description

Find more details in the design doc:

go/submit-cl-based-on-cq-history
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/800791b08fb908032fd5787737a7cdb71b13bb03

commit 800791b08fb908032fd5787737a7cdb71b13bb03
Author: Ningning Xia <nxia@chromium.org>
Date: Sat May 27 19:32:25 2017

Get CLActions with ignore_patch_number and start_time options.

If ignore_patch_number is True, only get CLActions with matched
patch_number.
If start_time is provided, only get CLActions with timestamp after
start_time.
Add build status to CLAction.

BUG= chromium:725711 
TEST=unit_tests; cidb_integration_test

Change-Id: I93a374e1d4df6d6c9f2539242c66e45bfac30071
Reviewed-on: https://chromium-review.googlesource.com/516303
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/800791b08fb908032fd5787737a7cdb71b13bb03/lib/clactions_unittest.py
[modify] https://crrev.com/800791b08fb908032fd5787737a7cdb71b13bb03/lib/clactions.py
[modify] https://crrev.com/800791b08fb908032fd5787737a7cdb71b13bb03/lib/cidb.py
[modify] https://crrev.com/800791b08fb908032fd5787737a7cdb71b13bb03/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/800791b08fb908032fd5787737a7cdb71b13bb03/lib/fake_cidb.py
[modify] https://crrev.com/800791b08fb908032fd5787737a7cdb71b13bb03/appengine/cq_stats/build_annotations/build_row_controller.py
[modify] https://crrev.com/800791b08fb908032fd5787737a7cdb71b13bb03/lib/cidb_integration_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9434f5396072c24844cb2b1a72b53e980c8fdd5e

commit 9434f5396072c24844cb2b1a72b53e980c8fdd5e
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Jun 08 02:01:00 2017

Consider CQs passed in history in TriageRelevantChanges.

When TriageRelevantChanges triages relevant slave statuses for changes and
decides whether to stop waiting for slaves, it will consider the CQ slaves
passed in history for the changes it's checking.

BUG= chromium:725711 
TEST=unit_tests;cidb_integration_test

Change-Id: Idf5c5815912a408ee1fc6a85b4861863b44ad21f
Reviewed-on: https://chromium-review.googlesource.com/517321
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/9434f5396072c24844cb2b1a72b53e980c8fdd5e/cbuildbot/relevant_changes.py
[modify] https://crrev.com/9434f5396072c24844cb2b1a72b53e980c8fdd5e/lib/cidb.py
[modify] https://crrev.com/9434f5396072c24844cb2b1a72b53e980c8fdd5e/cbuildbot/relevant_changes_unittest.py
[modify] https://crrev.com/9434f5396072c24844cb2b1a72b53e980c8fdd5e/lib/cros_build_lib.py
[modify] https://crrev.com/9434f5396072c24844cb2b1a72b53e980c8fdd5e/lib/fake_cidb.py
[modify] https://crrev.com/9434f5396072c24844cb2b1a72b53e980c8fdd5e/lib/cros_build_lib_unittest.py
[modify] https://crrev.com/9434f5396072c24844cb2b1a72b53e980c8fdd5e/lib/cidb_integration_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9c90e594e41bb426deb546148e863bed1cc9ddeb

commit 9c90e594e41bb426deb546148e863bed1cc9ddeb
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Jun 08 02:01:00 2017

Record relevant_to_slave action to CIDB for relevant changes.

BUG= chromium:725711 
TEST=unit_tests

Change-Id: I4a06d1d713adcaf40eb577216e04acd83196a699
Reviewed-on: https://chromium-review.googlesource.com/522888
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/9c90e594e41bb426deb546148e863bed1cc9ddeb/lib/constants.py
[modify] https://crrev.com/9c90e594e41bb426deb546148e863bed1cc9ddeb/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/9c90e594e41bb426deb546148e863bed1cc9ddeb/cbuildbot/stages/report_stages.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6d242923094fd86cea80e147b5fb4a0e5edf2544

commit 6d242923094fd86cea80e147b5fb4a0e5edf2544
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Jun 08 04:14:35 2017

Consider CQs passed in history in SubmitPartialPool

1) Do not skip SubmitPartialPool if certain important slaves didn't pass
the critical stages.
2) Take CQ slave builds passed in history into consideration when
calculating fully_verified_changes for SubmitPartialPool.

BUG= chromium:725711 
TEST=unit_tests

Change-Id: Ic0d87d4552c460e26c3eed9359fb7b1c874a13f7
Reviewed-on: https://chromium-review.googlesource.com/517903
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/cbuildbot/validation_pool.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/cbuildbot/relevant_changes.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/cbuildbot/relevant_changes_unittest.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/lib/triage_lib_unittest.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/lib/constants.py
[modify] https://crrev.com/6d242923094fd86cea80e147b5fb4a0e5edf2544/lib/triage_lib.py

Comment 6 by nxia@chromium.org, Jun 20 2017

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Untriaged)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment