Issue metadata
Sign in to add a comment
|
Native heap profiling is broken on windows |
||||||||||||||||||||||||
Issue descriptionThe renderer process is crashing on every page when using: --enable-heap-profiling This is happening since that commit: https://chromium.googlesource.com/chromium/src/+/bd599af5d33647f0b498311eab05be79fac98e63 I validate the build before and this one and I can confirm that the bug is from the previous commit. Strangely, it's working well if we are adding --no-sandbox
,
Jun 28 2017
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d67edfacd27840c9c9713dae5bc1a413ed9eb998 commit d67edfacd27840c9c9713dae5bc1a413ed9eb998 Author: Lalit Maganti <lalitm@google.com> Date: Tue Sep 05 19:58:39 2017 Use 16 shards in sharded allocators except on Mac Using 64 causes renderer processes to request too much memory when heap profiling and sandbox are enabled and the renderer process crashes on Linux. Changing to 16 as on Windows resolves the crash. Making everything but Mac use this code path ensures we are more conservative except on Mac where this is believed to work. Bug: 725705 Change-Id: I547fe4bda994f867270fef0d76b01a289305b00d Reviewed-on: https://chromium-review.googlesource.com/650358 Commit-Queue: Lalit Maganti <lalitm@google.com> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#499719} [modify] https://crrev.com/d67edfacd27840c9c9713dae5bc1a413ed9eb998/base/trace_event/sharded_allocation_register.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by etienneb@chromium.org
, Jun 5 2017