New issue
Advanced search Search tips

Issue 725698 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Possible interactions between conditionally enabled context features and DidAccessInitialDocument

Project Member Reported by dcheng@chromium.org, May 23 2017

Issue description

I was reviewing https://chromium-review.googlesource.com/c/509390/, and it occurs to me that installing conditional features on the global may end up calling DidAccessInitialDocument().

Are there any Blink unit tests that exercise origin trials/are there any test-only origin trial things I can toggle on? I'd rather not depend on a random origin trial in https://cs.chromium.org/chromium/src/out/Debug/gen/blink/core/origin_trials/OriginTrials.h?type=cs.
 
Cc: cha...@chromium.org
There is a test-only origin trial interface on the internals object -- see third_party/WebKit/Source/core/testing/OriginTrialsTest.idl and friends, installed onto the internals object in third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp.

We don't have a test-only interface on the global object, if that's what you're looking for. I think we considered it, but decided not to because at the time it was going to require shipping the test interface with the browser, rather than being able to isolate it to content_shell. That may have changed since we made that decision, so we might be able to add one; it would still be installed in WebCoreTestSupport, very similarly to the way that we add interfaces to V8WindowPartial in InstallConditionalFeaturesForModules.
Status: Available (was: Unconfirmed)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 8 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: peria@chromium.org
Status: Assigned (was: Untriaged)
peria@, would you check if we're calling DidAccessInitialDocument() or not?  Having a test is a separate issue.  I'm concerned about the timing of calling DidAccessInitialDocument().

Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment