New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725693 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Restore group separator for Smart Select menu item

Reported by ti...@chromium.org, May 23 2017

Issue description

The spec wants it, TextView has it.
The separator is actually a group separator, the assist item just has to belong to a distinct menu group.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e10e9f196add35245bba8e7b74b1baa7085072

commit 78e10e9f196add35245bba8e7b74b1baa7085072
Author: timav <timav@chromium.org>
Date: Wed May 24 18:07:49 2017

[Smarttext selection] Restore separator between assist and other items

The spec recommends having a separator between an assist item (map,
phone, etc.) and others. The separator is a menu group separator,
we enable it by having a separate menu group for the assist item.

BUG= 725693 

Review-Url: https://codereview.chromium.org/2903733002
Cr-Commit-Position: refs/heads/master@{#474355}

[modify] https://crrev.com/78e10e9f196add35245bba8e7b74b1baa7085072/content/public/android/java/res/menu/select_action_menu.xml
[modify] https://crrev.com/78e10e9f196add35245bba8e7b74b1baa7085072/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Comment 2 by ti...@chromium.org, May 24 2017

Labels: Merge-Request-59 M-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 24 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-59 Merge-Rejected-59
Talked to Tima, we can wait for M60.  Purely cosmetic.

Comment 5 by ti...@chromium.org, Jun 2 2017

Labels: -M-59 M-60
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
verified on Pixel XL / OPR1.170607.001 vs 60.0.3112.20

Sign in to add a comment