Tapping on Zine articles crashes when Chrome Home enabled |
||||||||||||
Issue descriptionMore fall out from my Chrome Home NTP redesign 05-23 15:31:31.532 30293 30293 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.chrome.browser.tab.Tab.addObserver(org.chromium.chrome.browser.tab.TabObserver)' on a null object reference 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at org.chromium.chrome.browser.ntp.NewTabPageUma.monitorContentSuggestionVisit(NewTabPageUma.java:268) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegateImpl.openSnippet(SuggestionsNavigationDelegateImpl.java:113) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder.onCardTapped(SnippetArticleViewHolder.java:166) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at org.chromium.chrome.browser.ntp.cards.CardViewHolder$1.onClick(CardViewHolder.java:107) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at android.view.View.performClick(View.java:5637) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at android.view.View$PerformClick.run(View.java:22429) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:751) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:95) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at android.os.Looper.loop(Looper.java:154) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:6119) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886) 05-23 15:31:31.532 30293 30293 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)
,
May 24 2017
The repro steps for this bug are: With Chrome Home enabled: 1) Open a new tab 2) Tap an NTP snippet The change that caused this landed in 60.0.3108.0 and is a top crasher in the current canary, so we need a fix before next week's dev push.
,
May 24 2017
Issue 725859 has been merged into this issue.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a09eb44c2529b669b00191c0613db43542c7708 commit 4a09eb44c2529b669b00191c0613db43542c7708 Author: twellington <twellington@chromium.org> Date: Wed May 24 16:13:46 2017 [Home] Wait to monitor NTP content suggestions until new tab created With the new Chrome Home NTP design, a new tab isn't created until the user navigations inside the NTP. While the Chrome Home NTP is open, the active tab is null. Wait to call NewTabPageUma.monitorContentSuggestionsVisit() until after the suggestion URL has been loaded, which ensures the active tab is not null. BUG= 725688 Review-Url: https://codereview.chromium.org/2904713002 Cr-Commit-Position: refs/heads/master@{#474316} [modify] https://crrev.com/4a09eb44c2529b669b00191c0613db43542c7708/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
,
May 24 2017
,
May 25 2017
Issue 726153 has been merged into this issue.
,
May 26 2017
,
May 26 2017
We are able to repro this issue on chrome:60.0.3112.0 Device:Pixel/OPP2.170420.019 Steps to reproduce: 1.Launch Chrome 2.Enable chrome Home from Chrome://flags 3.Open a New tab 4.Tap on any Snippet Frequency:100% Observed Behavior:Chrome Crashed Expected behavior: Chrome should not crash Additional comments: **It is reproducible in Chrome:60.0.3111.0 But not reproducible in 60.0.3110.0
,
May 26 2017
Crash id :dbc5ce18e8000000
,
May 26 2017
,
May 26 2017
Assigning to tedchoc@ while twellington@ is out.
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/189dd02cbb3d5187ee70e67d51a09f6d274d3a6a commit 189dd02cbb3d5187ee70e67d51a09f6d274d3a6a Author: tedchoc <tedchoc@chromium.org> Date: Fri May 26 22:03:44 2017 Ensure BottomSheet#getActiveTab returns non-null after load. BUG= 725688 Review-Url: https://codereview.chromium.org/2909693002 Cr-Commit-Position: refs/heads/master@{#475154} [modify] https://crrev.com/189dd02cbb3d5187ee70e67d51a09f6d274d3a6a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
,
May 26 2017
,
May 26 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7ada5f724cc309250567463caf4d0dcb448628e commit d7ada5f724cc309250567463caf4d0dcb448628e Author: Ted Choc <tedchoc@google.com> Date: Fri May 26 23:54:39 2017 Ensure BottomSheet#getActiveTab returns non-null after load. BUG= 725688 Review-Url: https://codereview.chromium.org/2909693002 Cr-Original-Commit-Position: refs/heads/master@{#475154} Review-Url: https://codereview.chromium.org/2901393007 . Cr-Commit-Position: refs/branch-heads/3112@{#7} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/d7ada5f724cc309250567463caf4d0dcb448628e/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
,
May 27 2017
,
May 27 2017
There's no reason for this to be rvg
,
May 29 2017
,
May 30 2017
Issues verified on 60.0.3112.7, No crashes observed while tapping on zine articles. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by twelling...@chromium.org
, May 23 2017