New issue
Advanced search Search tips

Issue 725649 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: App button no longer exits WebVR presentation

Project Member Reported by cjgrant@chromium.org, May 23 2017

Issue description

As of approximately Friday, the app button no longer exits WebVR presentation.  Instead, the last-rendered WebVR content floats in space like a quad.

bsheedy@ reported that CL 2889693005 broke VrShell navigation tests, so I'm verifying that it caused this regression as well.

Assigning to tiborg@ as he had started investigating.
 
Suspect CL is confirmed.

Comment 2 by tiborg@chromium.org, May 23 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8955f1c68c20bc97db9d800be8a13bcc6631b38

commit d8955f1c68c20bc97db9d800be8a13bcc6631b38
Author: tiborg <tiborg@chromium.org>
Date: Wed May 24 18:26:15 2017

Fix exiting WebVR present.

- Previously, exiting WebVR present would stop WebVR rendering but not tell VrShell to exit presenting mode.

BUG= 725649 

Review-Url: https://codereview.chromium.org/2903573004
Cr-Commit-Position: refs/heads/master@{#474361}

[modify] https://crrev.com/d8955f1c68c20bc97db9d800be8a13bcc6631b38/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Comment 4 by tiborg@chromium.org, May 24 2017

Status: Fixed (was: Started)
Labels: Proj-VR

Sign in to add a comment