New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725629 link

Starred by 1 user
Status: Fixed
Owner:
█ nek...@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
aleventhal@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Previous line is announced when on a blank line right at the end of text field

Project Member Reported by nek...@chromium.org, May 23 2017 
<textarea>
hello
</textarea>

Position the caret on the blank line at the end of the textarea.
Call IAccessibleText::get_textAtOffset(IA2_CARET_OFFSET, IA2_BOUNDARY_LINE);
Observe that the previous line "Hello" is returned and that the start offset is 0 and the end offset is 6, even though the caret offset is correctly set to 6 - right after the newline.
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21b5bb81bf3acaad3f32f53950b4aeb1496724d7

commit 21b5bb81bf3acaad3f32f53950b4aeb1496724d7
Author: nektar <nektar@chromium.org>
Date: Fri May 26 01:11:06 2017

Fixed bugs with finding line boundaries using IA2 get_textAtOffset and AXPosition::AtStartOfLine.

1. AXPosition can handle offsets at the end of text, so no need to do "--offset" in get_textAtOffset when offset == text length.
2. The end boundary should be found based on the start boundary, not based on the original offset to error-out for situations when both the start and end boundaries are before the original offset.
3. AXPosition::AtStartOfLine should report |true| for text positions that are right after a newline when that newline is before some text. This is because visually the position is at the start of a new line. In practice this situation only occurs at the end of a text field.
4. COM return values should be set to defaults (0 and nullptr) when the operation fails.
BUG= 725629 
R=dmazzoni@chromium.org
CC=aleventhal@chromium.org
TESTED=manually with Jaws, unit tests

Review-Url: https://codereview.chromium.org/2897163002
Cr-Commit-Position: refs/heads/master@{#474861}

[modify] https://crrev.com/21b5bb81bf3acaad3f32f53950b4aeb1496724d7/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/21b5bb81bf3acaad3f32f53950b4aeb1496724d7/content/browser/accessibility/browser_accessibility_com_win.h
[modify] https://crrev.com/21b5bb81bf3acaad3f32f53950b4aeb1496724d7/ui/accessibility/ax_node_position_unittest.cc
[modify] https://crrev.com/21b5bb81bf3acaad3f32f53950b4aeb1496724d7/ui/accessibility/ax_position.h

Comment 2 by dmazz...@chromium.org, Aug 4 2017

Labels: triage-dominic

Comment 3 by dmazz...@chromium.org, Aug 10 2017

Labels: -triage-dominic

Comment 4 by nek...@chromium.org, Dec 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment