New issue
Advanced search Search tips

Issue 725614 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

BiquadFilter and IIRFilter should set responses to NaN for invalid frequencies

Project Member Reported by rtoy@chromium.org, May 23 2017

Issue description

The spec says that getFrequencyResponse should fill the output arrays with NaN if the corresponding frequency value is out of range: https://webaudio.github.io/web-audio-api/#widl-BiquadFilterNode-getFrequencyResponse-void-Float32Array-frequencyHz-Float32Array-magResponse-Float32Array-phaseResponse
 

Comment 1 by rtoy@chromium.org, May 24 2017

Cc: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58476b85b941b408e2c79eb2dc58661f11674e4f

commit 58476b85b941b408e2c79eb2dc58661f11674e4f
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu May 25 19:07:21 2017

getFrequencyResponse should return NaN for invalid frequencies

For both the BiquadFilter and the IIRFilter, the getFrequencyResponse
method should return NaN when the frequency value is out of bounds
(less than 0 or above the Nyquist frequency).

BUG= 725614 
TEST=biquad-getFrequencyResponse.html, 
iirfilter-getFrequencyResponse.html

Change-Id: I659d5666828e44782815e67a0b35c37668c6253c
Reviewed-on: https://chromium-review.googlesource.com/513342
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474741}
[delete] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-iirfilternode-interface/test-iirfilternode-expected.txt
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-getFrequencyResponse.html
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/Source/platform/audio/Biquad.cpp
[modify] https://crrev.com/58476b85b941b408e2c79eb2dc58661f11674e4f/third_party/WebKit/Source/platform/audio/IIRFilter.cpp

Comment 3 by rtoy@chromium.org, May 26 2017

Status: Fixed (was: Started)

Sign in to add a comment