New issue
Advanced search Search tips

Issue 725613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Handle expired year in CC expiration year dropdown.

Project Member Reported by rouslan@chromium.org, May 23 2017

Issue description

Handle expired year in CC expiration year dropdown.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47e012dc18b9182214af6f93f05518e635dd4674

commit 47e012dc18b9182214af6f93f05518e635dd4674
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue May 23 21:29:30 2017

Handle expired cards in desktop web payment UI.

Before this patch, editing a card may not show the card's expiration
year in the dropdown, if that year is prior to the current year or past
10 years from now. This results in either user confusion or inability to
edit a card correctly.

This patch always includes the card's expiration year in the dropdown.
If the card is already expired, the its expiration year is at the top of
the dropdown. If the card expires more than 10 years from now, then its
expiration year is at the bottom of the dropdown.

Bug:  725613 
Change-Id: I968c45545ebc3605e43a4b9f6ceb4a3793cc5e33
Reviewed-on: https://chromium-review.googlesource.com/513323
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474061}
[modify] https://crrev.com/47e012dc18b9182214af6f93f05518e635dd4674/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/47e012dc18b9182214af6f93f05518e635dd4674/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment