Layout Test payments/payment-request-interface.html is flaky |
||
Issue descriptionThe following layout test is flaky on all platforms. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20(dbg)/builds/1712 is one example of a failed build, but it regularly fails on all platforms. payments/payment-request-interface.html Actual output sometimes has some number of "CONSOLE ERROR: Uncaught (in promise) UnknownError: Request failed" in its output, while the test expectations don't have any of these. The correct fix is probably to get rid of the test expectation file, and fix the failures the -expected.txt file is complaining about (passing null to assert_throws).
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4046a030fc7d1617ddddfd383f0e62ea3915b622 commit 4046a030fc7d1617ddddfd383f0e62ea3915b622 Author: mek <mek@chromium.org> Date: Tue May 23 20:16:43 2017 Mark payments/payment-request-interface.html as flaky. BUG= 725585 TBR=rouslan@chromium.org Review-Url: https://codereview.chromium.org/2896333002 Cr-Commit-Position: refs/heads/master@{#474028} [modify] https://crrev.com/4046a030fc7d1617ddddfd383f0e62ea3915b622/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d71aa8beba49aa8dc7814176e8795243035b4d05 commit d71aa8beba49aa8dc7814176e8795243035b4d05 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Fri Jun 02 22:06:17 2017 Explicit error type in PaymentRequest layout test. Bug: 725585 Change-Id: I11bade77643d93529b3d3d0d2025cf2990a57210 Reviewed-on: https://chromium-review.googlesource.com/523103 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#476808} [modify] https://crrev.com/d71aa8beba49aa8dc7814176e8795243035b4d05/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/f4f805f9fb47f434766195909c50a46b484ffdbb/third_party/WebKit/LayoutTests/payments/payment-request-interface-expected.txt [modify] https://crrev.com/d71aa8beba49aa8dc7814176e8795243035b4d05/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
,
Jun 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rouslan@chromium.org
, May 23 2017