New issue
Advanced search Search tips

Issue 725570 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Consider using Mojo's process error callback in Chrome Cleaner's IPC

Project Member Reported by alito@chromium.org, May 23 2017

Issue description

When setting up the Mojo IPC between Chrome and the Chrome Cleaner process, a call is made to mojo::edk::OutgoingBrokerClientInvitation::Send(), which optionally takes a process error callback. That callback is called if Mojo rejects a message from a process, but does not otherwise indicate anything else. In particular it does not indicate that the pipe is broken or that the process has terminated.

The process error callback can be dispatched from any thread at any time (even after a connection error has been dispatched to indicate that the pipe is broken) so it is kind of hard to deal with.

On the other hand, it might be worth investigating if it could be useful somehow. For example, should we try to close the pipe if it is still up and running and we recieve a process error callback indicating that a message has been rejected?
 

Comment 1 by alito@chromium.org, Nov 6 2017

Status: WontFix (was: Assigned)
We don't need to use the process error callback since it will only be dispatched on errors that we catch. Since we don't need to verify the message contents ourselves, the process error callback is not useful for us.

Sign in to add a comment