New issue
Advanced search Search tips

Issue 725567 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 718486



Sign in to add a comment

[Buffer] Support the "buffered" flag in observers for paint, longtasks etc.

Project Member Reported by panicker@chromium.org, May 23 2017

Issue description

We want to support this for observe() for all entry types, but could start with paint, longtasks.

 
Owner: maxlg@chromium.org
Max, I think we'll put this on your backlog.
It's lower priority than the rest of your work currently.

Comment 2 by maxlg@chromium.org, Jun 30 2017

I am looking at https://github.com/w3c/performance-timeline/pull/76
The WebIdl looks like this: 

dictionary PerformanceObserverInit {
  required sequence<DOMString> entryTypes;
  boolean buffered = false;
};

But it's not in PerformanceObserverInit yet. https://cs.chromium.org/chromium/src/out/Debug/gen/blink/core/timing/PerformanceObserverInit.h?dr=CSs

So the scope of this issue includes creating a 'buffered' flag according to the spec? And the issue 718486 (https://bugs.chromium.org/p/chromium/issues/detail?id=718486) is based on this issue, is it right? 

Yup, your interpretation sounds correct to me.

Feel free to block that bug on this one.

Comment 4 by maxlg@chromium.org, Jul 4 2017

Blockedon: 718486

Comment 5 by maxlg@chromium.org, Jul 10 2017

Blockedon: -718486
Blocking: 718486

Comment 6 by maxlg@chromium.org, Aug 1 2017

Status: Started (was: Available)

Comment 7 by maxlg@chromium.org, Aug 24 2017

I am not clear about the roadmap of this issue. There doesn't seem to be specs or tests around the buffered flag for paint and longtasks in https://w3c.github.io/performance-timeline yet. 
I don't think the relation between the buffered flag and specific entry types needs to be specified. The spec for "buffered":

> Let entries be the PerformanceEntryList object returned by the 4.2 Filter 
> buffer by name and type algorithm with buffer set to performance entry 
> buffer, name set to null and type set to entryType.

That implicitly applies to all entryTypes.

Comment 9 by maxlg@google.com, Aug 30 2017

Sorry I misread this issue. My focus was on long-task and paint. Actually the focus of this issue should be to support the behavior of the buffered flag in general. And the longtask part should instead be solved in Issue 718486. 
Blocking: 758385

Comment 11 by maxlg@chromium.org, Oct 10 2017

Summary: [Buffer] Support the "buffered" flag in observers for paint, longtasks etc. (was: Support the "buffered" flag in observers for paint, longtasks etc.)

Comment 12 by maxlg@google.com, Jan 10 2018

Blocking: -758385

Comment 13 by maxlg@chromium.org, Apr 23 2018

Update: already scheduled to work on it in this quarter.

Comment 14 by npm@chromium.org, Jun 18 2018

The title of this bug mentions longtasks, which makes me wonder: will we actually observe previous longtasks with the buffered flag? I think these are not added to the performance buffer, so if we want the buffered flag to work for longtasks then we need to modify the spec.
Yeah, we do want this to work for longtasks.
Hey Max: any update on this bug? Looks like it's been in progress since Q2, but isn't done yet.
Status: Assigned (was: Started)
Haven't worked on this for a while after it get de-prioritized.

There was an WIP CL (https://chromium-review.googlesource.com/c/chromium/src/+/641382) but I believe a lot has changed. Will restart the task at some point. But for now I will move it back to assigned. 
Labels: -Pri-3 Pri-2
Owner: eyaich@chromium.org

Sign in to add a comment