New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 725532 link

Starred by 1 user
Status: Fixed
Owner:
changwan@chromium.org
Closed: May 2017
Cc:
█ yolandyan@chromium.org
█ aelias@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

content_shell_test_apk failing on chromium.linux/Android Tests

Project Member Reported by mek@chromium.org, May 23 2017 
org.chromium.content.browser.input.ImeTest#testFinishComposingText and 
 org.chromium.content.browser.input.ImeTest#testNavigateTextWithDpadKeyCodes started consistently failing with build https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/41992

Nothing in that build seems to have touched anything that should be relevant though...

Builders failed on: 
- Android Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests

Comment 2 by changwan@chromium.org, May 23 2017

Cc: aelias@chromium.org
Components: UI>Input>Text>IME
Status: Started (was: Available)
I suspect that renderer change caused this. Investigating.

Comment 3 by changwan@chromium.org, May 23 2017 

My initial suspicion is https://codereview.chromium.org/2856093003,
because the failure started a bit earlier at 41987: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/41987

Comment 4 by changwan@chromium.org, May 23 2017 

I could not reproduce the issue locally, I'll have to speculatively revert the CL from comment #3 and revert #1 to check if this issue will go away or not.

Comment 5 by changwan@chromium.org, May 23 2017

Labels: Pri-1
Some of these test failures are critical both for users and developers, so marking as P1.

Comment 6 by ekaramad@chromium.org, May 23 2017 

I was wondering if this CL could also have caused it?
https://codereview.chromium.org/2894383003/

which seems to have landed around the same time as the CL in comment #3.

Comment 7 by mek@chromium.org, May 23 2017 

That same CL was also pointed out as possibly culprit for bug #725470 fwiw

Comment 8 by changwan@chromium.org, May 23 2017 

Re #6, #7, I'll be monitoring buildbot and revert it as well if necessary. Thanks.
Project Member

Comment 9 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3c088d58adeab44de2d05269c5b92391712f292

commit f3c088d58adeab44de2d05269c5b92391712f292
Author: changwan <changwan@chromium.org>
Date: Tue May 23 19:19:34 2017

Revert of Disable two failing Android IME tests. (patchset #1 id:1 of https://codereview.chromium.org/2898213002/ )

Reason for revert:
reverted https://codereview.chromium.org/2856093003 speculatively, re-enabling the tests.

Original issue's description:
> Disable two failing Android IME tests.
>
> BUG= 725532 
> TBR=changwan@chromium.org
>
> Review-Url: https://codereview.chromium.org/2898213002
> Cr-Commit-Position: refs/heads/master@{#473936}
> Committed: https://chromium.googlesource.com/chromium/src/+/0c754f5b68742378978be850e0779159d9de53b1

TBR=mek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 725532 

Review-Url: https://codereview.chromium.org/2902813002
Cr-Commit-Position: refs/heads/master@{#474010}

[modify] https://crrev.com/f3c088d58adeab44de2d05269c5b92391712f292/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Comment 10 by changwan@chromium.org, May 23 2017

Status: Fixed (was: Started)
The culprit (https://codereview.chromium.org/2856093003) has been reverted. Marking as fixed.
►

Sign in to add a comment