New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725524 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Share logic between ios/chrome and ios/web_view.

Project Member Reported by michaeldo@chromium.org, May 23 2017

Issue description

Chrome and ChromeWebView framework on iOS should be able to share top level logic when possible. There is currently not a good place to put shared logic. (Potentially a component for shared iOS logic would work.)
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e8fc527dd73f46682283810a01445672e475b80

commit 5e8fc527dd73f46682283810a01445672e475b80
Author: michaeldo <michaeldo@chromium.org>
Date: Tue May 30 19:18:27 2017

Move common functionality of IOSChromeIOThread to ios/components.

Most of this functionality is not reliant on ios/chrome. Moving it to
ios/components allows it to be used by ios/web_view. The existing
unittest is left in place because it relies on the setup that happens in
the IOSChromeUnitTestSuite class.

BUG= 725524 

Review-Url: https://codereview.chromium.org/2908613002
Cr-Commit-Position: refs/heads/master@{#475627}

[modify] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/BUILD.gn
[modify] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/chrome/browser/DEPS
[modify] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/chrome/browser/ios_chrome_io_thread.h
[modify] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/chrome/browser/ios_chrome_io_thread.mm
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/BUILD.gn
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/DEPS
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/README.md
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/io_thread/BUILD.gn
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/io_thread/DEPS
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/io_thread/ios_io_thread.h
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/io_thread/ios_io_thread.mm
[add] https://crrev.com/5e8fc527dd73f46682283810a01445672e475b80/ios/components/io_thread/ios_io_thread_unittest.mm

Status: Fixed (was: Assigned)
ios/components has been created for this shared code location to live.
Labels: -Type-Bug Type-Task
Status: Assigned (was: Fixed)
There is still a todo in the code referencing the bug
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a855f2c363b8372560eb21d9d7935cd3b0c5055

commit 5a855f2c363b8372560eb21d9d7935cd3b0c5055
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Fri Jan 05 18:15:51 2018

Remove share script TODO.

There is no need to try to share this script. This script is not
replicated verbatim as chrome has the ability to click(), focus(), or
submit() with a single helper function.

Bug:  725524 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifdd2592fdf865ff73dba332352b5a71f40116ce7
Reviewed-on: https://chromium-review.googlesource.com/849196
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527319}
[modify] https://crrev.com/5a855f2c363b8372560eb21d9d7935cd3b0c5055/ios/web_view/test/web_view_test_util.mm

Status: Fixed (was: Assigned)
TODO removed.

Sign in to add a comment