Share logic between ios/chrome and ios/web_view. |
||||
Issue descriptionChrome and ChromeWebView framework on iOS should be able to share top level logic when possible. There is currently not a good place to put shared logic. (Potentially a component for shared iOS logic would work.)
,
May 30 2017
ios/components has been created for this shared code location to live.
,
Jun 14 2017
There is still a todo in the code referencing the bug
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a855f2c363b8372560eb21d9d7935cd3b0c5055 commit 5a855f2c363b8372560eb21d9d7935cd3b0c5055 Author: Mike Dougherty <michaeldo@chromium.org> Date: Fri Jan 05 18:15:51 2018 Remove share script TODO. There is no need to try to share this script. This script is not replicated verbatim as chrome has the ability to click(), focus(), or submit() with a single helper function. Bug: 725524 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifdd2592fdf865ff73dba332352b5a71f40116ce7 Reviewed-on: https://chromium-review.googlesource.com/849196 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#527319} [modify] https://crrev.com/5a855f2c363b8372560eb21d9d7935cd3b0c5055/ios/web_view/test/web_view_test_util.mm
,
Jan 5 2018
TODO removed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 30 2017