New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725519 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression


Participants' hotlists:
Hotlist-1


Sign in to add a comment

Chrome freezes if <input> within <div> uses contenteditable="false"

Reported by dkilgarr...@gmail.com, May 23 2017

Issue description

Chrome Version       : 58.0.3029.110 (64-bit)
URLs (if applicable) : https://jsfiddle.net/nkxfo9nb/1/ , https://embed.plnkr.co/Cj1xr3j47tUO3v6ugTZd/
Other browsers tested:
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari:
    Firefox: OK. 53.0.3 (32-bit)
         IE:

What steps will reproduce the problem?
(1) Create a <div> element with contenteditable="true"
(2) Create an <input> element inside this <div>
(3) Set contenteditable="false" on the input
(4) Attempt to interact with the input by highlighting it or clicking it.

What is the expected result?
Text/element should be highlighted or focused.

What happens instead?
Chrome tab freezes and becomes unresponsive. 

Please provide any additional information below. Attach a screenshot if
possible.
URL's provided above for reproduction. Attached html as textfile also.

    


 
chrome-content-editable-bug.txt
561 bytes View Download
Cc: ligim...@chromium.org
Components: Blink
Labels: -Pri-3 Needs-Triage-M58 Needs-Bisect Pri-1

Comment 2 by rtoy@chromium.org, May 23 2017

Cc: rtoy@chromium.org
Labels: Needs-Feedback
Can't reproduce this with Chrome 59 (beta).  I can highlight the text and chrome doesn't seem to freeze in anyway.
I've downloaded Version 59.0.3071.61 (Official Build) beta (64-bit) and I can still reproduce this on the jsfiddle and plnkr links above. 
Project Member

Comment 4 by sheriffbot@chromium.org, May 24 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rtoy@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by rtoy@chromium.org, May 24 2017

Labels: Needs-Feedback
What OS? I tried both tests on Chrome 59.0.3071.61 (Official Build) beta (64-bit) on Linux and can't reproduce the issue.  I can highlight the text in box and edit it and highlight the text.
Apologies, OS is Windows 7.
Project Member

Comment 7 by sheriffbot@chromium.org, May 25 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rtoy@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: pbomm...@chromium.org
Labels: M-59 OS-Windows
This looks similar to issue#716093 which is fixed in latest Chrome Beta i.e., 59.0.3071.71.

 dkilgarriff@ if possible can you please update Chrome Beta and check if you can still reproducible if so please let us know.
Labels: Needs-Feedback
I don't have permission to view issue#716093.

I have retested on Version 59.0.3071.71 and the issue still occurs. 

Reproduction steps:
Starting from the bottom of the page, highlight all the text upwards including the <input> element.

Result:
The tab freezes.

Note:
Issue does not occur if text is selected from the top of the page downwards.
Project Member

Comment 11 by sheriffbot@chromium.org, May 26 2017

Cc: brajkumar@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: hdodda@chromium.org
Labels: -Type-Bug -Needs-Bisect -M-59 hasbisect-per-revision M-60 OS-Linux OS-Mac Type-Bug-Regression
Owner: yosin@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue on Mac os 10.12.4 , windows 7 and ubuntu 14.04 suing chrome M58 # 58.0.3029.110 and M60 #60.0.3115.0 and issue is reproduced.

This is regression issue broken in M58 .

Using the per-revision bisect providing the bisect results,
Good build: 58.0.3027.0 (Revision: 453800).
Bad build: 58.0.3029.0 (Revision: 454471).

You are probably looking for a change made after 454235 (known good), but no later than 454236 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspectas some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/23972357b3fb5591905c94528ee39ae1d1351f34..2211504ac2b999a125b2215ce7f6be9e50878fea

From the CL above, assigning the issue to the concern owner 

@yosin- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2720593005

Thanks!
Components: -Blink Blink>Editing
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
Lower to Pri-2, since setting contentEditable=false for INPUT is unusual, since INPUT element doesn't have child nodes.

On ToT, the hang is occurred when selection bottom to top.
The infinite loop is in VisibleSelection::AdjustSelectionToAvoidCrossingEditingBoundaries()
where |p| are
 - BeforeAnchor(INPUT)
 - "contenteditable='false'"[0] by NextVisibleDistinceCandiate(BeforeAnchor(INPUT))
 - <div>"contenteditable='false'</div>[1] by NextVisibleDistinctCandiate("contenteditable='false'"[0])
Note: NextVisibleDistinctCandidate(<div>"contenteditable='false'</div>[1]) = null






Comment 15 by yosin@chromium.org, Jan 10 2018

Labels: Pri-3
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment