PlatformDisplayDefault fails to init |
||
Issue description
Running BrowserTest.NoTitle in mash_browser_tests produces the following crash.
Run: ./out/${OUT_DIR}/browser_tests --run-in-mash --gtest_filter=BrowserTest.NoTitle
[0523/105025.094086:FATAL:post_task.cc(72)] Check failed: TaskScheduler::GetInstance(). Ref. Prerequisite section of post_task.h
#0 0x7f7e2a813ddb base::debug::StackTrace::StackTrace()
#1 0x7f7e2a812b1c base::debug::StackTrace::StackTrace()
#2 0x7f7e2a87ecf7 logging::LogMessage::~LogMessage()
#3 0x7f7e2a99cf3a base::PostDelayedTaskWithTraits()
#4 0x7f7e2a99d162 base::PostTaskWithTraits()
#5 0x7f7e0e8a8459 ui::X11HotplugEventHandler::OnHotplugEvent()
#6 0x7f7e0e8a6d24 ui::X11EventSource::OnDispatcherListChanged()
#7 0x7f7e0e8b4669 ui::X11EventSourceLibevent::OnDispatcherListChanged()
#8 0x7f7e25741bb4 ui::PlatformEventSource::AddPlatformEventDispatcher()
#9 0x7f7e0e858f8f ui::X11WindowOzone::X11WindowOzone()
#10 0x7f7e1ab87f71 _ZN4base10MakeUniqueIN2ui14X11WindowOzoneEJPNS1_21X11WindowManagerOzoneERPNS1_22PlatformWindowDelegateERKN3gfx4RectEEEENS_8internal16MakeUniqueResultIT_E6ScalarEDpOT0_
#11 0x7f7e1ab86d98 ui::(anonymous namespace)::OzonePlatformX11::CreatePlatformWindow()
#12 0x0000089ebb8d ui::ws::PlatformDisplayDefault::Init()
#13 0x0000089cddf2 ui::ws::Display::Init()
#14 0x000008950f82 ui::ws::DisplayManager::OnDisplayAdded()
#15 0x000003b26bbf display::ScreenManagerOzoneInternal::OnDisplayAdded()
#16 0x7f7e1ba06253 display::DisplayManager::NotifyDisplayAdded()
#17 0x7f7e1ba0273f display::DisplayManager::UpdateDisplaysWith()
#18 0x7f7e1ba00128 display::DisplayManager::OnNativeDisplaysChanged()
#19 0x7f7e1b9c12e8 display::DisplayChangeObserver::OnDisplayModeChanged()
#20 0x7f7e1b9cec48 display::DisplayConfigurator::NotifyDisplayStateObservers()
#21 0x7f7e1b9ccd79 display::DisplayConfigurator::OnConfigured()
#22 0x7f7e1b9d9bb9 _ZN4base8internal13FunctorTraitsIMN7display19DisplayConfiguratorEFvbRKNSt7__debug6vectorIPNS2_15DisplaySnapshotESaIS7_EEERKN3gfx4SizeENS2_20MultipleDisplayStateEN8chromeos17DisplayPowerStateEEvE6InvokeIRKNS_7WeakPtrIS3_EEJbSB_SF_SG_SI_EEEvSK_OT_DpOT0_
#23 0x7f7e1b9d9a70 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN7display19DisplayConfiguratorEFvbRKNSt7__debug6vectorIPNS4_15DisplaySnapshotESaIS9_EEERKN3gfx4SizeENS4_20MultipleDisplayStateEN8chromeos17DisplayPowerStateEERKNS_7WeakPtrIS5_EEJbSD_SH_SI_SK_EEEvOT_OT0_DpOT1_
#24 0x7f7e1b9d9983 _ZN4base8internal7InvokerINS0_9BindStateIMN7display19DisplayConfiguratorEFvbRKNSt7__debug6vectorIPNS3_15DisplaySnapshotESaIS8_EEERKN3gfx4SizeENS3_20MultipleDisplayStateEN8chromeos17DisplayPowerStateEEJNS_7WeakPtrIS4_EEEEEFvbSC_SG_SH_SJ_EE7RunImplIRKSL_RKSt5tupleIJSN_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEObSC_SG_OSH_OSJ_
#25 0x7f7e1b9d9861 _ZN4base8internal7InvokerINS0_9BindStateIMN7display19DisplayConfiguratorEFvbRKNSt7__debug6vectorIPNS3_15DisplaySnapshotESaIS8_EEERKN3gfx4SizeENS3_20MultipleDisplayStateEN8chromeos17DisplayPowerStateEEJNS_7WeakPtrIS4_EEEEEFvbSC_SG_SH_SJ_EE3RunEPNS0_13BindStateBaseEObSC_SG_OSH_OSJ_
#26 0x7f7e1b9f9e7d _ZNKR4base8CallbackIFvbRKNSt7__debug6vectorIPN7display15DisplaySnapshotESaIS5_EEERKN3gfx4SizeENS3_20MultipleDisplayStateEN8chromeos17DisplayPowerStateEELNS_8internal8CopyModeE1ELNSI_10RepeatModeE1EE3RunEbS9_SD_SE_SG_
#27 0x7f7e1b9f9916 display::UpdateDisplayConfigurationTask::FinishConfiguration()
#28 0x7f7e1b9f987d display::UpdateDisplayConfigurationTask::OnStateEntered()
#29 0x7f7e1b9fa91e _ZN4base8internal13FunctorTraitsIMN7display30UpdateDisplayConfigurationTaskEFvNS2_21ConfigureDisplaysTask6StatusEEvE6InvokeIRKNS_7WeakPtrIS3_EEJS5_EEEvS7_OT_DpOT0_
#30 0x7f7e1b9fa86f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN7display30UpdateDisplayConfigurationTaskEFvNS4_21ConfigureDisplaysTask6StatusEERKNS_7WeakPtrIS5_EEJS7_EEEvOT_OT0_DpOT1_
#31 0x7f7e1b9fa7e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7display30UpdateDisplayConfigurationTaskEFvNS3_21ConfigureDisplaysTask6StatusEEJNS_7WeakPtrIS4_EEEEEFvS6_EE7RunImplIRKS8_RKSt5tupleIJSA_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOS6_
#32 0x7f7e1b9fa71c _ZN4base8internal7InvokerINS0_9BindStateIMN7display30UpdateDisplayConfigurationTaskEFvNS3_21ConfigureDisplaysTask6StatusEEJNS_7WeakPtrIS4_EEEEEFvS6_EE3RunEPNS0_13BindStateBaseEOS6_
#33 0x7f7e1b9bc0b1 _ZNKR4base8CallbackIFvN7display21ConfigureDisplaysTask6StatusEELNS_8internal8CopyModeE1ELNS5_10RepeatModeE1EE3RunES3_
#34 0x7f7e1b9bb45f display::ConfigureDisplaysTask::Run()
#35 0x7f7e1b9bb7b6 display::ConfigureDisplaysTask::OnConfigured()
#36 0x7f7e1b9bf1cc _ZN4base8internal13FunctorTraitsIMN7display21ConfigureDisplaysTaskEFvmbEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKmbEEEvS5_OT_DpOT0_
#37 0x7f7e1b9bf094 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN7display21ConfigureDisplaysTaskEFvmbERKNS_7WeakPtrIS5_EEJRKmbEEEvOT_OT0_DpOT1_
#38 0x7f7e1b9beff8 _ZN4base8internal7InvokerINS0_9BindStateIMN7display21ConfigureDisplaysTaskEFvmbEJNS_7WeakPtrIS4_EEmEEEFvbEE7RunImplIRKS6_RKSt5tupleIJS8_mEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOb
#39 0x7f7e1b9beefc _ZN4base8internal7InvokerINS0_9BindStateIMN7display21ConfigureDisplaysTaskEFvmbEJNS_7WeakPtrIS4_EEmEEEFvbEE3RunEPNS0_13BindStateBaseEOb
#40 0x7f7e1fbaa6b9 _ZNKR4base8CallbackIFvbELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEb
#41 0x7f7e1fbb0092 _ZN4base8internal13FunctorTraitsINS_8CallbackIFvbELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEvE6InvokeIRKS6_JRKbEEEvOT_DpOT0_
#42 0x7f7e1fbaff62 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS_8CallbackIFvbELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJRKbEEEvOT_DpOT0_
#43 0x7f7e1fbaff22 _ZN4base8internal7InvokerINS0_9BindStateINS_8CallbackIFvbELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJbEEEFvvEE7RunImplIRKS7_RKSt5tupleIJbEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#44 0x7f7e1fbafe3c _ZN4base8internal7InvokerINS0_9BindStateINS_8CallbackIFvbELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJbEEEFvvEE3RunEPNS0_13BindStateBaseE
#45 0x7f7e1fbab89d _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#46 0x7f7e1fba963e display::FakeDisplayDelegate::ConfigureDone()
#47 0x7f7e1fbb1055 _ZN4base8internal13FunctorTraitsIMN7display19FakeDisplayDelegateEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#48 0x7f7e1fbb0f71 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7display19FakeDisplayDelegateEFvvEJPS5_EEEvOT_DpOT0_
#49 0x7f7e1fbb0f17 _ZN4base8internal7InvokerINS0_9BindStateIMN7display19FakeDisplayDelegateEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#50 0x7f7e1fbb0e5c _ZN4base8internal7InvokerINS0_9BindStateIMN7display19FakeDisplayDelegateEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#51 0x7f7e2a7cfabd _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#52 0x7f7e2a9f63e2 base::Timer::RunScheduledTask()
#53 0x7f7e2a9f6509 base::BaseTimerTaskInternal::Run()
#54 0x7f7e2a82cd65 _ZN4base8internal13FunctorTraitsIMNS_21FileDescriptorWatcher10Controller7WatcherEFvvEvE6InvokeIPS4_JEEEvS6_OT_DpOT0_
#55 0x7f7e2a9f66d1 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMNS_21BaseTimerTaskInternalEFvvEJPS4_EEEvOT_DpOT0_
#56 0x7f7e2a9f6677 _ZN4base8internal7InvokerINS0_9BindStateIMNS_21BaseTimerTaskInternalEFvvEJNS0_12OwnedWrapperIS3_EEEEEFvvEE7RunImplIS5_St5tupleIJS7_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#57 0x7f7e2a9f65be _ZN4base8internal7InvokerINS0_9BindStateIMNS_21BaseTimerTaskInternalEFvvEJNS0_12OwnedWrapperIS3_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#58 0x7f7e2a7d321e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#59 0x7f7e2a8192d1 base::debug::TaskAnnotator::RunTask()
#60 0x7f7e2a8a3a1e base::MessageLoop::RunTask()
#61 0x7f7e2a8a3c87 base::MessageLoop::DeferOrRunPendingTask()
,
May 24 2017
This is also failing in the mus_browser_tests, blocking our ability to detect other failures. If a fix will take a while would you object to me reverting the offending patch?
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6552fc43089472109de62975dbb91553d7dc19df commit 6552fc43089472109de62975dbb91553d7dc19df Author: jonross <jonross@chromium.org> Date: Wed May 24 22:22:15 2017 Revert "Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc." The change being reverted has led to failures in mash_browser_tests and mus_browser_tests. These are currently failing on the Mojo FYI bots. We are attempting to bring up more tests on the CQ, but cannot as they are failing with this change. This has led to bugs landing that would have normally been caught by the test suite. Revert "Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc." This reverts commit 4560bffcd8250247bbabe4f3f045ea7fa0d901ba. TBR=sadrul@chromium.org, danakj@chromium.org TEST=mash_browser_tests BUG= 725505 , 659191 Review-Url: https://codereview.chromium.org/2899313003 Cr-Commit-Position: refs/heads/master@{#474447} [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/content/browser/compositor/software_output_device_ozone_unittest.cc [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/compositor/test/test_suite.cc [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/compositor/test/test_suite.h [modify] https://crrev.com/6552fc43089472109de62975dbb91553d7dc19df/ui/events/platform/x11/x11_hotplug_event_handler.cc
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d1c63eff65ce57eee8a59bfdd400b38a4d0e1bf commit 0d1c63eff65ce57eee8a59bfdd400b38a4d0e1bf Author: Francois Doray <fdoray@chromium.org> Date: Wed Jun 07 18:11:25 2017 Initialize TaskScheduler in mash_browser_tests_main.cc. TaskScheduler is already initialized in services/service_manager/public/cpp/standalone_service/main.cc. It should also be initialized in mash_browser_tests_main.cc before running a standalone service to provide a similar environment in tests and in production. Bug: 664996 , 725505 Change-Id: I15373b9dcc185c0cbeee7efcafca1c9a9d5dd349 Reviewed-on: https://chromium-review.googlesource.com/523803 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#477705} [modify] https://crrev.com/0d1c63eff65ce57eee8a59bfdd400b38a4d0e1bf/chrome/test/base/mash_browser_tests_main.cc
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b1abc96c88e58386b492c65055e28ac9672bedb commit 7b1abc96c88e58386b492c65055e28ac9672bedb Author: Francois Doray <fdoray@chromium.org> Date: Thu Jun 15 13:38:58 2017 [reland] Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc. Previously landed as https://codereview.chromium.org/2860703002 https://chromium-review.googlesource.com/c/523803/ should fix the issue that caused the revert. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG= 659191 , 725505 TBR=danakj@chromium.org Change-Id: Ie4177b0e7cb7d554ea9ef02dc26afd22942e59e7 Reviewed-on: https://chromium-review.googlesource.com/524023 Reviewed-by: Francois Doray <fdoray@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#479685} [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/content/browser/compositor/software_output_device_ozone_unittest.cc [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/compositor/test/test_suite.cc [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/compositor/test/test_suite.h [modify] https://crrev.com/7b1abc96c88e58386b492c65055e28ac9672bedb/ui/events/platform/x11/x11_hotplug_event_handler.cc
,
Jun 16 2017
CL relanded. Now that TaskScheduler is initialized in mash_browser_tests_main.cc https://chromium-review.googlesource.com/523803, no crash should occur. |
||
►
Sign in to add a comment |
||
Comment 1 by jonr...@chromium.org
, May 23 2017Status: Assigned (was: Available)