New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 725504 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ComputeTextRect

Project Member Reported by ClusterFuzz, May 23 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6729612360155136

Fuzzer: ifratric-browserfuzzer-v3
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000008
Crash State:
  blink::ComputeTextRect
  blink::FrameSelection::RevealSelection
  blink::Editor::FindString
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=473419:473589

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6729612360155136


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Components: Blink>Editing
Labels: M-60 Test-Predator-Correct-CLs
Owner: yoichio@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: yoichio
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/3638f51b033ad950d63f9186f7d0329a4eed48c9
Time: Mon May 22 10:52:02 2017
Lines 957 of file FrameSelection.cpp which potentially caused crash are changed in this cl (frame #1, "blink::FrameSelection::RevealSelection"). 

Lines 4163 of file VisibleUnits.cpp which potentially caused crash are changed in this cl (frame #0, "blink::ComputeTextRect").
Minimum distance from crash line to modified line: 0. (file: VisibleUnits.cpp, crashed on: 4160, modified: 4160).

@yoichio -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Status: Started (was: Assigned)

Comment 3 by yosin@chromium.org, May 25 2017

Labels: -Pri-1 Pri-3
Lower to Pri-3, since real world usage of window#find() is low.
Project Member

Comment 4 by ClusterFuzz, May 25 2017

Labels: OS-Mac
Project Member

Comment 5 by ClusterFuzz, Jun 20 2017

ClusterFuzz has detected this issue as fixed in range 480630:480680.

Detailed report: https://clusterfuzz.com/testcase?key=6729612360155136

Fuzzer: ifratric-browserfuzzer-v3
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000008
Crash State:
  blink::ComputeTextRect
  blink::FrameSelection::RevealSelection
  blink::Editor::FindString
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=473419:473589
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=480630:480680

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6729612360155136


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 20 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6729612360155136 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment