Plumb visibility through FrameGenerator |
||||
Issue descriptionCurrently, the cc::Display associated with GpuRootCompositorFrameSink is always visible (in fact we make it visible in the constructor). Visibility is something that can change. We should plumb visibility from PlatformDisplayDefault to FrameGenerator through the DisplayPrivate interface to the cc::Display in GpuRootCompositorFrameSink.
,
May 26 2017
https://cs.chromium.org/chromium/src/ui/views/mus/desktop_window_tree_host_mus.cc?type=cs&l=413 We should not be plumbing visibility through ui::Compositor.
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b25d13803bb416cb482ea956129a73e40b5a9e8d commit b25d13803bb416cb482ea956129a73e40b5a9e8d Author: Alex Zhang <staraz@chromium.org> Date: Fri May 26 20:07:58 2017 Set visibility to true upon creation of DisplayPrivate GpuRootCompositorFrameSink no longer set Display visible in its constructor, instead, PlatformDisplayDefault calls SetDisplayVisible(true) immediately after establishing the mojo connection to DisplayPrivate. Plumbing visibility to the client side helps us eventually support mus chrome running on platforms that have external window managers (e.g. Linux). Bug: 725501 Change-Id: I189d03cb21afa5cc5b9f606b8dbb960abdaf0bb6 Reviewed-on: https://chromium-review.googlesource.com/516965 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#475098} [modify] https://crrev.com/b25d13803bb416cb482ea956129a73e40b5a9e8d/components/viz/frame_sinks/gpu_root_compositor_frame_sink.cc [modify] https://crrev.com/b25d13803bb416cb482ea956129a73e40b5a9e8d/services/ui/ws/platform_display_default.cc
,
May 29 2017
,
Jun 13 2017
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by fsam...@chromium.org
, May 23 2017