New issue
Advanced search Search tips

Issue 725495 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

CM API credentials aren't autofilled

Project Member Reported by vasi...@chromium.org, May 23 2017 
Chrome Version: 59
OS: all

Since the launch of Credential Manager API the credentials saved by navigator.credentials aren't autofilled. Instead they are filled on account select because we don't know the action URL. That constraint makes no sense and the CM API credentials should be treated as Android ones.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f676517d2d8b840c41eb67a7f874a154e7f54a

commit 40f676517d2d8b840c41eb67a7f874a154e7f54a
Author: vasilii <vasilii@chromium.org>
Date: Wed May 24 14:37:18 2017

Ignore form action URL when determine if a credential should be autofilled.

The Credential Manager API saves passwords without action like Android does. The former credentials should be treated as the latter ones.
As a side effect the CL fixes an apparently buggy condition for the change password forms coming from r335019. Before: Android credentials were autofilled into the change password forms. Now: the are offered in the drop-down like normal web credentials.

BUG= 725495 

Review-Url: https://codereview.chromium.org/2900983002
Cr-Commit-Position: refs/heads/master@{#474284}

[modify] https://crrev.com/40f676517d2d8b840c41eb67a7f874a154e7f54a/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/40f676517d2d8b840c41eb67a7f874a154e7f54a/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/40f676517d2d8b840c41eb67a7f874a154e7f54a/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/40f676517d2d8b840c41eb67a7f874a154e7f54a/chrome/browser/password_manager/password_manager_test_base.h
[modify] https://crrev.com/40f676517d2d8b840c41eb67a7f874a154e7f54a/components/password_manager/core/browser/password_form_manager.cc

Comment 2 by vasi...@chromium.org, May 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment